Bugfix/demo offline 1623 #1624
Closed
Bugfix/demo offline 1623 #1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing offline attribute to OfflineConfiguration parameter.
Call configureCertificate before Store and Delete calls, when certificateUri is given. Fixes shaka-project#1623.
|
Looking deeper, I see that you already store the certificate itself, so no need to retrieve an original certificateUri and get a certificate before calling Storage.remove(). So please ignore the 2nd commit 03759600375960, it should be modified and extended. By the way, the current 250-beta-master branch has other Storage related errors. |
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi,
In this fix I am taking the certificateUri from an originalAsset [if one is] found in the shakaAssets array.
This is an intermediate fix.
A better solution would be to store the certificateUri in storage
together with the original license server uri.
I will open another issue for that, as I intend to suggest to store also a separate releaseLicenseServerUri.