Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ShakaPlayer v2.2.0 shows subtitles of previous stream #984

Closed
avelad opened this issue Aug 24, 2017 · 6 comments
Closed

ShakaPlayer v2.2.0 shows subtitles of previous stream #984

avelad opened this issue Aug 24, 2017 · 6 comments
Assignees
@joeyparrish
Labels
flag: Why didn't we catch this sooner This issue is embarassing; we may still need an automated test that could have prevented this issue status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v2.3.0

Comments

@avelad
Copy link
Member

avelad commented Aug 24, 2017

What version of Shaka Player are you using:
v2.2.0

Can you reproduce the issue with our latest release version:
Yes

Can you reproduce the issue with the latest code from master:
Yes

Are you using the demo app or your own custom app:
Demo app

What browser and OS are you using:
Chrome 50 Ubuntu 17.04: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.101 Safari/537.36

What did you do?
Enable the subtitles (CC button), reproduce Angel One some seconds (20 seconds eg) and then load Sintel 4K.

What did you expect to happen?
Sintel 4K shows his subtitles.

What actually happened?
Sintel 4K shows Angel One subtitles and his subtitles.

Aug 24 2017 9-47 AM.webm.zip
@chrisfillmore
Copy link
Contributor

I've also seen this in the demo app.

@joeyparrish joeyparrish added needs triage type: bug Something isn't working correctly and removed needs triage labels Aug 24, 2017
@joeyparrish joeyparrish added this to the v2.3.0 milestone Aug 24, 2017
@joeyparrish
Copy link
Member

Confirmed on v2.2.0. Not present in v2.1.8. This is probably a bug in our default text displayer. The text displayer plugin interface was introduced in v2.2.0 and was not present in v2.1.x.

@joeyparrish joeyparrish self-assigned this Aug 24, 2017
@joeyparrish
Copy link
Member

This fix will be available in the nightly build tomorrow. We will also release this fix in v2.2.1.

@joeyparrish joeyparrish added the flag: Why didn't we catch this sooner This issue is embarassing; we may still need an automated test that could have prevented this issue label Aug 24, 2017
@avelad
Copy link
Member Author

avelad commented Aug 25, 2017

Are there release date for v2.2.1?

@joeyparrish
Copy link
Member

I'm planning to wait until next week, so we can deal with incoming bug reports about v2.2.0. You can always try the master branch in the mean time.

joeyparrish added a commit that referenced this issue Aug 31, 2017
@joeyparrish
Fix TextDisplayer remembering old cues
c81bfed 
Instead of destroying the TextDisplayer instance when the Player is
destroyed, it should be destroyed when the Player resets for another
piece of content.  This way, old cues are removed before we start
streaming new media.

Fixes #984

Change-Id: I9f417682a6f79eb2190404876b0bcb4b670040ad
@joeyparrish
Copy link
Member

Cherry-picked to v2.2.1

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joeyparrish joeyparrish

Labels
flag: Why didn't we catch this sooner This issue is embarassing; we may still need an automated test that could have prevented this issue status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v2.3.0
Development

No branches or pull requests
4 participants
@joeyparrish @chrisfillmore @avelad @shaka-bot