Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isAudioOnly to player interface #942

Closed
avelad opened this issue Jul 25, 2017 · 1 comment
Closed

Add isAudioOnly to player interface #942

avelad opened this issue Jul 25, 2017 · 1 comment
Assignees
@joeyparrish
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone
v2.2.0

Comments

@avelad
Copy link
Member

avelad commented Jul 25, 2017

Is it possible to add an isAudioOnly to player interface, in the same way as isInProgress eg.?

Note: in the demo app, the form for get this is not very clear: https://github.com/google/shaka-player/blob/master/demo/asset_section.js#L211-L219
@joeyparrish joeyparrish added the type: enhancement New feature or request label Jul 25, 2017
@joeyparrish joeyparrish added this to the v2.2.0 milestone Jul 25, 2017
@joeyparrish
Copy link
Member

Good idea! This should be easy to do.

@joeyparrish joeyparrish mentioned this issue Aug 14, 2017
Closed
joeyparrish added a commit that referenced this issue Aug 16, 2017
@joeyparrish
Add player.isAudioOnly()
104f1a7 
This simplifies detection of audio-only content and makes the process
a little more obvious.

Closes #942

Backported to v2.1.x for issue #969

Change-Id: I89b599fb8c8915c9e1b45d2f9b81a3ac7193e5ef
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joeyparrish joeyparrish

Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v2.2.0
Development

No branches or pull requests
3 participants
@joeyparrish @avelad @shaka-bot