-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request to expose audio track role #767
Comments
I think we can do that! Let me tentatively schedule it for 2.2 (tentatively in case our project visionaries don't approve :)). Please note, that we don't have separate audio/video tracks anymore. Instead we have variant tracks which represent audio+video combinations. (This was introduced in 2.1 release which just went out). |
Yep, I've taken that into account in the Shaka/dash.js compatible video.js plugin I'm working on |
+1 for this. Will |
I don't see why not. We'll do that, as well. |
Great thanks. If you prefer that to be in a separate issue I'm happy to make a new one. |
No, I think we can do that here. |
@joeyparrish How do see audio track role coexisting with the label attribute being added by PR #811? |
There can only be one label (one Both accomplish similar goals. Whichever is used by your content/encoder, we will expose the information so that your application can use it to make decisions. |
This change is to expose an audio track's role in order to differentiate among a main / caption / commentary track that shares the same language. Issue #767. Change-Id: I05d38cba2170d0005611cf160b7ae45996fe77dd
This change is to expose an audio track's role in order to differentiate among a main / caption / commentary track that shares the same language. Issue #767. Change-Id: I05d38cba2170d0005611cf160b7ae45996fe77dd
The first part of this fix has been cherry-picked to v2.1.3. |
Exposing the roles of tracks, which come from the manifest, in the select audio language method. This is a follow up on commit b27861050c11451db57d87270ec1385c1906627a. Closes #767. Change-Id: Iebb873f1db8834c7275a8a9fc01c3b855c0288aa
This is a enhancement request for exposing an audio track's role in order to differentiate between a main English track and commentary (or any other role type that can share a language).
The text was updated successfully, but these errors were encountered: