fix: Prefer SimpleTextDisplayer on iOS #7569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
changed the title
avelad
added
component: demo page
tykus160
approved these changes
Nov 12, 2024
This comment was marked as outdated.
This comment was marked as outdated.
avelad
changed the title
avelad
removed
the
component: demo page
tykus160
approved these changes
Nov 12, 2024
joeyparrish
requested changes
Nov 12, 2024
joeyparrish
reviewed
Nov 12, 2024
lib/player.js
Outdated
| // On devices where the Fullscreen API is not available we prefer | ||
| // SimpleTextDisplayer because it works with the Fullscreen API of the | ||
| // video element itself. | ||
| if (this.videoContainer_ && document.fullscreenEnabled) { |
There was a problem hiding this comment.
I think this should be a little more subtle. If you had a device without a fullscreen API of any kind, we would still want UITextDisplayer. The issue is that we end up on the WebKit-specific video-only fullscreen method, which breaks UITextDisplayer.
I think what we really want is something like this.videoContainer_ && (shouldUseDocumentFullscreen(this.config_) || !isFullScreenSupported()), where shouldUseDocumentFullscreen and isFullScreenSupported are extracted from ui/controls.js and made static.
Is this too subtle/complex?
There was a problem hiding this comment.
Since this only happens on iOS, I think I'll make a simpler version
joeyparrish
approved these changes
Nov 13, 2024
This was referenced Nov 13, 2024
avelad
added a commit
that referenced
this pull request
Nov 15, 2024
avelad
added a commit
that referenced
this pull request
Nov 15, 2024
joeyparrish
pushed a commit
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7568