Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No captions in fullscreen mode on iPhone (iOS) in Shaka demo #7568

Closed
jakubkrolikowski opened this issue Nov 12, 2024 · 6 comments · Fixed by #7569
Closed

No captions in fullscreen mode on iPhone (iOS) in Shaka demo #7568

jakubkrolikowski opened this issue Nov 12, 2024 · 6 comments · Fixed by #7569
Assignees
Labels
component: captions/subtitles The issue involves captions or subtitles component: demo page The issue is in the demo page; does not affect production applications platform: iOS Issues affecting iOS priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Milestone

Comments

@jakubkrolikowski
Copy link

Have you read the FAQ and checked for duplicate open issues?

yes

If the problem is related to FairPlay, have you read the tutorial?

What version of Shaka Player are you using?

4.11.12

Can you reproduce the issue with our latest release version?
yes

Can you reproduce the issue with the latest code from main?
yes

Are you using the demo app or your own custom app?
demo and custom

If custom app, can you reproduce the issue using our demo app?
yes

What browser and OS are you using?
Safari on iOS 17.5.1 (iPhone 12)

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?

Default demo Angel One from:
https://shaka-player-demo.appspot.com/demo/#audiolang=en-US;textlang=en-US;uilang=en-US;panel=HOME;build=uncompiled

What configuration are you using? What is the output of player.getNonDefaultConfiguration()?

Demo default configuration.

What did you do?

Play demo Angel One on iPhone, turn on captions, turn on full screen mode.

What did you expect to happen?
Captions / subtitles will be visible.

What actually happened?

No caption in fullscreen mode.

Are you planning send a PR to fix it?
No.
Looks like in normal mode caption are rendered by Shaka text displayer. They disapear on fullscreen mode.
I think subtitles should be rendered in this case by native IOS player.

@jakubkrolikowski jakubkrolikowski added the type: bug Something isn't working correctly label Nov 12, 2024
@avelad
Copy link
Member

avelad commented Nov 12, 2024

This only happens with UITextDisplayer, with SimpleTextDisplayer this does not happen.

@avelad avelad added component: captions/subtitles The issue involves captions or subtitles platform: iOS Issues affecting iOS labels Nov 12, 2024
@avelad avelad added component: demo page The issue is in the demo page; does not affect production applications priority: P2 Smaller impact or easy workaround labels Nov 12, 2024
@jakubkrolikowski
Copy link
Author

This only happens with UITextDisplayer, with SimpleTextDisplayer this does not happen.

I guess Shaka demo player uses defualt SimpleTextDisplayer, right?

@avelad
Copy link
Member

avelad commented Nov 12, 2024

This only happens with UITextDisplayer, with SimpleTextDisplayer this does not happen.

I guess Shaka demo player uses defualt SimpleTextDisplayer, right?

Yes

@avelad avelad added this to the v4.12 milestone Nov 12, 2024
@jakubkrolikowski
Copy link
Author

This only happens with UITextDisplayer, with SimpleTextDisplayer this does not happen.

I guess Shaka demo player uses defualt SimpleTextDisplayer, right?

Yes

So I can reproduce this bug on my iPhone playing demo Angel One, which uses a SimpleTextDisplayer.

@joeyparrish
Copy link
Member

This only happens with UITextDisplayer, with SimpleTextDisplayer this does not happen.

I guess Shaka demo player uses defualt SimpleTextDisplayer, right?

Yes

No, I believe the default for the demo is UITextDisplayer, since we are using the full UI.

@avelad
Copy link
Member

avelad commented Nov 12, 2024

This only happens with UITextDisplayer, with SimpleTextDisplayer this does not happen.

I guess Shaka demo player uses defualt SimpleTextDisplayer, right?

Yes

No, I believe the default for the demo is UITextDisplayer, since we are using the full UI.

Oh yeah, it depends on whether you use Shaka UI or not.

@avelad avelad modified the milestones: v4.12, v4.13 Nov 13, 2024
@avelad avelad self-assigned this Nov 13, 2024
@avelad avelad closed this as completed in bd2c9a7 Nov 13, 2024
avelad added a commit that referenced this issue Nov 15, 2024
avelad added a commit that referenced this issue Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: captions/subtitles The issue involves captions or subtitles component: demo page The issue is in the demo page; does not affect production applications platform: iOS Issues affecting iOS priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants