Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(UI): Disable fullscreen button conditionally when playing ads #7534

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Nov 4, 2024

Only disable fullscreen button when the devices doesn't support the standard Fullscreen API and playing an ad that use another media element

Fixes #6133

Only disable fullscreen button when the devices doesn't support the standard Fullscreen API and playing an ad that use another media element
@avelad avelad added type: bug Something isn't working correctly component: UI The issue involves the Shaka Player UI component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround platform: iOS Issues affecting iOS labels Nov 4, 2024
@avelad avelad added this to the v4.12 milestone Nov 4, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 77.50%

@avelad avelad merged commit 1497148 into shaka-project:main Nov 4, 2024
25 checks passed
@avelad avelad deleted the cs-disable-fullscreenButton branch November 4, 2024 11:54
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jan 3, 2025
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs component: UI The issue involves the Shaka Player UI platform: iOS Issues affecting iOS priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client side ads not playing in iOS fullscreen
3 participants