Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client side ads not playing in iOS fullscreen #6133

Closed
Andekas opened this issue Jan 22, 2024 · 6 comments · Fixed by #7534
Closed

Client side ads not playing in iOS fullscreen #6133

Andekas opened this issue Jan 22, 2024 · 6 comments · Fixed by #7534
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs platform: iOS Issues affecting iOS priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@Andekas
Copy link

Andekas commented Jan 22, 2024

Have you read the FAQ and checked for duplicate open issues?
Yes

If the problem is related to FairPlay, have you read the tutorial?

Not related

What version of Shaka Player are you using?

Latest, 4.7.6

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from main?
Yes

Are you using the demo app or your own custom app?
Demo app

If custom app, can you reproduce the issue using our demo app?
Yes

What browser and OS are you using?
iOS - Chrome, Safari, Firefox

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?

For content, any (demo) URL is good.

For ads I used Google IMA VMAP sample tags ( https://developers.google.com/interactive-media-ads/docs/sdks/html5/client-side/tags )

What configuration are you using? What is the output of player.getConfiguration()?

Default

What did you do?

Try to play video with ads

What did you expect to happen?
Ads and video to play

What actually happened?

Ads work great when player is not in fullscreen.

On fullscreen, no ads are displayed. When going to fullscreen during an ad (rotating the device to landscape), the ad sound keeps playing but main video is visible (paused). If ad(s) end, video starts playing.

@Andekas Andekas added the type: bug Something isn't working correctly label Jan 22, 2024
@avelad
Copy link
Member

avelad commented Jan 22, 2024

Are you interested in finding and create a PR to fix the error? Thanks!

@avelad avelad added component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround platform: iOS Issues affecting iOS labels Jan 22, 2024
@shaka-bot shaka-bot added this to the v5.0 milestone Jan 22, 2024
@Andekas
Copy link
Author

Andekas commented Jan 23, 2024

@avelad I'm afraid that I'm not that familiar with Apple devices. As I use Win/Android, it would be really difficult to debug also...

@avelad
Copy link
Member

avelad commented Jan 23, 2024

The fullscreen API is not available on iOS (https://caniuse.com/fullscreen) so we use the fullscreen API of the video element itself and it produces this behavior.
I see two solutions:

  • Disable the full screen button in browsers that do not support the fullscreen API and are using IMA CS.
  • When an ad is going to be played, exit fullscreen, and disable the fullscreen button during the ad, the problem is that we cannot return to fullscreen afterwards because a user action is necessary.

Which solution do you like best? (You probably won't like any...)

@avelad avelad added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Jan 23, 2024
@Andekas
Copy link
Author

Andekas commented Jan 24, 2024

@avelad Thanks for looking it up!

I guess that the best solution would be to disable the fullscreen button / rotation during the ads, if fullscreen API is not supported.

In this case user is forced to see at least preroll. And if he goes to fullscreen after preroll and doesn't get any midrolls, it's acceptable. Exiting fullscreen to display ads is a really bad user experience, I would say.

@avelad
Copy link
Member

avelad commented Jan 24, 2024

@theodab What do you think?

@shaka-bot shaka-bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Jan 24, 2024
@PradeepK17
Copy link

@Andekas @avelad Please look this blog - IMA iOS10+ customPlayback. It may provide insights on how to address the problem.

@avelad avelad modified the milestones: v4.8, v4.9 Apr 26, 2024
@avelad avelad modified the milestones: v4.9, v4.10 May 30, 2024
@avelad avelad modified the milestones: v4.10, v4.11 Jul 1, 2024
@avelad avelad modified the milestones: v4.11, v4.12 Sep 12, 2024
@avelad avelad closed this as completed in 1497148 Nov 4, 2024
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jan 3, 2025
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs platform: iOS Issues affecting iOS priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants