Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client side ads not visible on iPad Chrome #6134

Closed
Andekas opened this issue Jan 22, 2024 · 4 comments
Closed

Client side ads not visible on iPad Chrome #6134

Andekas opened this issue Jan 22, 2024 · 4 comments
Labels
browser: Chrome Issues affecting Chrome or Chromium derivatives (except Edge) component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs platform: iOS Issues affecting iOS priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@Andekas
Copy link

Andekas commented Jan 22, 2024

Have you read the FAQ and checked for duplicate open issues?
Yes

If the problem is related to FairPlay, have you read the tutorial?

Not related

What version of Shaka Player are you using?

Latest, 4.7.6

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from main?
Yes

Are you using the demo app or your own custom app?
Demo app

If custom app, can you reproduce the issue using our demo app?
Yes

What browser and OS are you using?
iPad OS Chrome (everything works on iPad OS Safari)

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?

For content, any (demo) URL is good.

For ads I used Google IMA VMAP sample tags ( https://developers.google.com/interactive-media-ads/docs/sdks/html5/client-side/tags )

What configuration are you using? What is the output of player.getConfiguration()?

Default

What did you do?

Try to play video with ads

What did you expect to happen?
Ads and video to play

What actually happened?

Ads won't play, video plays good.

@Andekas Andekas added the type: bug Something isn't working correctly label Jan 22, 2024
@avelad
Copy link
Member

avelad commented Jan 22, 2024

Are you interested in finding and create a PR to fix the error? Thanks!

@avelad avelad added component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround browser: Chrome Issues affecting Chrome or Chromium derivatives (except Edge) platform: iOS Issues affecting iOS labels Jan 22, 2024
@shaka-bot shaka-bot added this to the v5.0 milestone Jan 22, 2024
@Andekas
Copy link
Author

Andekas commented Jan 23, 2024

@avelad I'm afraid that I'm not that familiar with Apple devices. As I use Win/Android, it would be really difficult to debug also...

@avelad
Copy link
Member

avelad commented Jan 23, 2024

Same issue as #6133

It appears that Chrome on iPadOS does not have access to the fullscreen API.

@avelad avelad added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Jan 23, 2024
@Andekas
Copy link
Author

Andekas commented Jan 24, 2024

@avelad It wasn't related, because ads weren't displaying at all (even when video wasn't on fullscreen).

I tested it again with two iPads (iPadAir iPadOS 17.1.1 and iPad mini 2 OS 12.5.7) and now everything works (both fullscreen and not). So maybe it was Chrome bug and fixed in some new version.

I close the issue and re-open it if I am able to reproduce it again.

@Andekas Andekas closed this as completed Jan 24, 2024
@shaka-bot shaka-bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Jan 24, 2024
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Mar 24, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Mar 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
browser: Chrome Issues affecting Chrome or Chromium derivatives (except Edge) component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs platform: iOS Issues affecting iOS priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

3 participants