Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtitles in HLS are shown too early #7447

Closed
mthie opened this issue Oct 20, 2024 · 4 comments · Fixed by #7625
Closed

Subtitles in HLS are shown too early #7447

mthie opened this issue Oct 20, 2024 · 4 comments · Fixed by #7625
Assignees
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@mthie
Copy link

mthie commented Oct 20, 2024

Have you read the FAQ and checked for duplicate open issues?

Yes.

If the problem is related to FairPlay, have you read the tutorial?

N/A

What version of Shaka Player are you using?

4.11.8 / latest

Can you reproduce the issue with our latest release version?

Yes.

Can you reproduce the issue with the latest code from main?

Yes.

Are you using the demo app or your own custom app?

Both.

If custom app, can you reproduce the issue using our demo app?

Yes.

What browser and OS are you using?

Windows 11, Chrome stable and beta.

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

N/A

What are the manifest and license server URIs?

https://cdn.contentflow.net/corporations/cSR2UwvAfK8yti4pErXo/workspaces/HavgCUYVXa6kAea0IkTK/media/44672e62-8555-4728-b131-794c00b2a6a6/index.m3u8

What configuration are you using? What is the output of player.getNonDefaultConfiguration()?

Plain default of the Demo Player.

What did you do?

Enable the subtitles and press play.

What did you expect to happen?

Show subtitles at the correct timestamp that is defined in the webvtt file.

What actually happened?

There's a subtitle starting within the first second of the video, but is not shown. The second subtitle, starting with second 00:02.880 is shown at the beginning of the 2nd second. The result is that subtitles are asynchronous to the spoken text and will be shown before the speaker speaks the first word of the current subtitle line.

It works fine with HLS.js.

Are you planning send a PR to fix it?

No.

@mthie mthie added the type: bug Something isn't working correctly label Oct 20, 2024
@shaka-bot shaka-bot added this to the v4.12 milestone Oct 20, 2024
@avelad avelad added component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release labels Oct 21, 2024
@avelad avelad self-assigned this Oct 21, 2024
@avelad
Copy link
Member

avelad commented Oct 21, 2024

With manifest.hls.sequenceMode = false your stream plays fine

@mthie
Copy link
Author

mthie commented Oct 21, 2024

You're right, but false is the default and without this option set it should work the same way, right?

@avelad
Copy link
Member

avelad commented Oct 21, 2024

Yes, but for now I propose this workaround, because I don't know when I will find time to fix the problem.

@mthie
Copy link
Author

mthie commented Oct 21, 2024

Sure, thank you for the workaround. :)

@avelad avelad modified the milestones: v4.12, v4.13 Nov 13, 2024
@avelad avelad closed this as completed in 9e2b15e Nov 19, 2024
joeyparrish pushed a commit that referenced this issue Nov 19, 2024
Simplifies subtitle management for sequence mode and segments mode 
Runs subtitle tests in segments mode as well (Tizen 3.0)

Fixes: #7447
joeyparrish pushed a commit that referenced this issue Nov 19, 2024
Simplifies subtitle management for sequence mode and segments mode 
Runs subtitle tests in segments mode as well (Tizen 3.0)

Fixes: #7447
joeyparrish pushed a commit that referenced this issue Nov 19, 2024
Simplifies subtitle management for sequence mode and segments mode 
Runs subtitle tests in segments mode as well (Tizen 3.0)

Fixes: #7447
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jan 18, 2025
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jan 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants