Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABR restrictToElementSize is applied even when ABR is disabled and overrides manual quality selections #7151

Closed
absidue opened this issue Aug 12, 2024 · 0 comments · Fixed by #7153
Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@absidue
Copy link

absidue commented Aug 12, 2024

Have you read the FAQ and checked for duplicate open issues?
Yes

If the problem is related to FairPlay, have you read the tutorial?
Not applicable

What version of Shaka Player are you using?
4.10.9

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from main?
Yes

Are you using the demo app or your own custom app?
Both

If custom app, can you reproduce the issue using our demo app?
Yes

What browser and OS are you using?
Firefox, Windows 10
Microsoft Edge, Windows 10

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
Not applicable

What are the manifest and license server URIs?
Can be reproduced with any manifest e.g. this one from the demo player: https://storage.googleapis.com/shaka-demo-assets/bbb-dark-truths-hls/hls.m3u8

What configuration are you using? What is the output of player.getConfiguration()?

{
  "abr": {
    "enabled": false,
    "restrictToElementSize": true
  },
}

What did you do?

  1. Turn on the abr.restrictToElementSize setting
  2. Start playing any manifest
  3. Pick a specific quality from the quality selector
  4. Resize the window/player

What did you expect to happen?
The player to stick to the selected quality because ABR is disabled.

What actually happened?
In debug builds and the demo player notice that Assertion failed: AbrManager should not call switch while disabled! is logged to the console. Additionally if you check the active variant with player.getVariantTracks().find(v => v.active) you'll notice that it doesn't match the one that you selected.

Are you planning send a PR to fix it?
Don't know enough about the internals to understand why ABR is running when it should be disabled.

@absidue absidue added the type: bug Something isn't working correctly label Aug 12, 2024
@absidue absidue changed the title ABR restrictToElementSize is applied even when ABR is disabled ABR restrictToElementSize is applied even when ABR is disabled and overrides manual quality selections Aug 12, 2024
@shaka-bot shaka-bot added this to the v4.11 milestone Aug 12, 2024
@avelad avelad added the priority: P2 Smaller impact or easy workaround label Aug 19, 2024
@avelad avelad closed this as completed in aea85b0 Aug 19, 2024
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Oct 18, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants