ABR restrictToElementSize
is applied even when ABR is disabled and overrides manual quality selections
#7151
Labels
priority: P2
Smaller impact or easy workaround
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
Milestone
Have you read the FAQ and checked for duplicate open issues?
Yes
If the problem is related to FairPlay, have you read the tutorial?
Not applicable
What version of Shaka Player are you using?
4.10.9
Can you reproduce the issue with our latest release version?
Yes
Can you reproduce the issue with the latest code from
main
?Yes
Are you using the demo app or your own custom app?
Both
If custom app, can you reproduce the issue using our demo app?
Yes
What browser and OS are you using?
Firefox, Windows 10
Microsoft Edge, Windows 10
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
Not applicable
What are the manifest and license server URIs?
Can be reproduced with any manifest e.g. this one from the demo player: https://storage.googleapis.com/shaka-demo-assets/bbb-dark-truths-hls/hls.m3u8
What configuration are you using? What is the output of
player.getConfiguration()
?What did you do?
abr.restrictToElementSize
settingWhat did you expect to happen?
The player to stick to the selected quality because ABR is disabled.
What actually happened?
In debug builds and the demo player notice that
Assertion failed: AbrManager should not call switch while disabled!
is logged to the console. Additionally if you check the active variant withplayer.getVariantTracks().find(v => v.active)
you'll notice that it doesn't match the one that you selected.Are you planning send a PR to fix it?
Don't know enough about the internals to understand why ABR is running when it should be disabled.
The text was updated successfully, but these errors were encountered: