Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working Patch Manifest with S[@t=<Timevalue>] #7128

Closed
Iragne opened this issue Aug 4, 2024 · 0 comments · Fixed by #7131
Closed

Not working Patch Manifest with S[@t=<Timevalue>] #7128

Iragne opened this issue Aug 4, 2024 · 0 comments · Fixed by #7131
Labels
component: DASH The issue involves the MPEG DASH manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@Iragne
Copy link
Contributor

Iragne commented Aug 4, 2024

Have you read the FAQ and checked for duplicate open issues?
Yes

If the problem is related to FairPlay, have you read the tutorial?

N/A

What version of Shaka Player are you using?

Latest

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from main?
Yes

Are you using the demo app or your own custom app?
Yes

If custom app, can you reproduce the issue using our demo app?
N/A

What browser and OS are you using?
FF and Chrome

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
N/A

What are the manifest and license server URIs?

What configuration are you using? What is the output of player.getConfiguration()?

Default

What did you do?

Just play a manifest with patch manifest inside and the patch manifest is using [@t=] instead of S[]
/MPD/Period[@id='1']/AdaptationSet[@id='1']/Representation[@id='3']/SegmentTemplate/SegmentTimeline/S[@t='1']/@r

according to the Dash spec you can use @t= and @n= to reference the position
What did you expect to happen?
S[@t=] to work
Doc ISO_IEC 23009-1_2022 ed.5 - id.83314 Publication PDF (en).pdf page 158
S elements shall be addressed in one of the following ways:
@t or @n attribute
— by position.

What actually happened?

the patch update is not updating the manifest stream timeline as expected
That is the reason why the stream here was not working
#7025

Are you planning send a PR to fix it?
Yes

@Iragne Iragne added the type: bug Something isn't working correctly label Aug 4, 2024
@shaka-bot shaka-bot added this to the v4.11 milestone Aug 4, 2024
@avelad avelad added priority: P1 Big impact or workaround impractical; resolve before feature release component: DASH The issue involves the MPEG DASH manifest format labels Aug 19, 2024
@avelad avelad closed this as completed in 0f2cea4 Aug 20, 2024
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Oct 19, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Oct 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: DASH The issue involves the MPEG DASH manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants