Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live content switching to VOD #6918

Closed
zubcoco opened this issue Jun 26, 2024 · 15 comments · Fixed by #7189
Closed

Live content switching to VOD #6918

zubcoco opened this issue Jun 26, 2024 · 15 comments · Fixed by #7189
Labels
component: DASH The issue involves the MPEG DASH manifest format priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@zubcoco
Copy link

zubcoco commented Jun 26, 2024

Hello,

We are a TV provider and we have LIVE content that can be transformed into VOD content.

In this case, the isLive method continues to return true even if the asset is transformed into VOD.

And in this case too, we don't receive the end event. We only receive a buffering event.

I've done the tests on the last shaka player version (4.9.10).

Have you an idea how to fix the bug and if it will be fixed in a future release ?

Thanks,
Corentin

@zubcoco zubcoco added the type: bug Something isn't working correctly label Jun 26, 2024
@shaka-bot shaka-bot added this to the v4.10 milestone Jun 26, 2024
@avelad
Copy link
Member

avelad commented Jun 26, 2024

Please fill out the bug template so we can help you! https://github.com/shaka-project/shaka-player/issues/new/choose

The conversion of Live to Vod works, but not all providers do it in the same way, so we have to look at the specific case.

Thanks!

@avelad avelad added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Jun 26, 2024
@zubcoco
Copy link
Author

zubcoco commented Jun 26, 2024

Have you read the FAQ and checked for duplicate open issues?
Yes

If the problem is related to FairPlay, have you read the tutorial?

No

What version of Shaka Player are you using?

Latest, v4.9.10

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from main?
Yes

Are you using the demo app or your own custom app?
Custom app

If custom app, can you reproduce the issue using our demo app?
Yes
I just try to play the asset on the demo app (https://shaka-player-demo.appspot.com/).
And we the live stream is closed, the seekbar is always a live seekbar (without duration) and after a while I can see the loading indicator.

What browser and OS are you using?
MacOS - Chrome

What are the manifest and license server URIs?

I'll send you 5 assets in the near futur.

What did you do?

Just playing and waiting the stream to close. At the end I don't receive the ended event, just a buffering event.

What did you expect to happen?
Receive the ended event.

What actually happened?

I receive the buffering event.

Are you planning send a PR to fix it?
No

@shaka-bot shaka-bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Jun 26, 2024
@avelad avelad added the component: DASH The issue involves the MPEG DASH manifest format label Jul 1, 2024
@avelad avelad modified the milestones: v4.10, v4.11 Jul 1, 2024
@avelad
Copy link
Member

avelad commented Jul 12, 2024

@zubcoco Can you review if the change of #7029 resolves your issue? Thanks!

@avelad avelad added status: waiting on response Waiting on a response from the reporter(s) of the issue priority: P2 Smaller impact or easy workaround labels Jul 12, 2024
@zubcoco
Copy link
Author

zubcoco commented Jul 16, 2024

My problem is not fixed in the latest release (v4.10.6) who contains the change of #7029 ...

@avelad avelad removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Jul 16, 2024
@avelad
Copy link
Member

avelad commented Aug 19, 2024

@zubcoco Can you send new assets so we can investigate the problem? Thanks!

@avelad avelad added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Aug 19, 2024
@Iragne
Copy link
Contributor

Iragne commented Aug 20, 2024

Happy to test this use case too

@avelad
Copy link
Member

avelad commented Aug 20, 2024

@Iragne this feature is not working for you?

@shaka-bot shaka-bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Aug 20, 2024
@Iragne
Copy link
Contributor

Iragne commented Aug 20, 2024

I will check in few hours we are doing live to VOD transition all the time and i'm quite worried about this bug

@avelad avelad added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Aug 20, 2024
@zubcoco
Copy link
Author

zubcoco commented Aug 21, 2024

@avelad I've sent some stream sample to reproduce the issue.
Thanks

@shaka-bot shaka-bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Aug 21, 2024
@avelad
Copy link
Member

avelad commented Aug 21, 2024

@zubcoco I can reproduce the issue with version 4.10.10, but not with the main branch. So some commit will have fixed this (I don't know which one). and the fix will appear in version 4.11

@avelad avelad added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Aug 21, 2024
@Iragne
Copy link
Contributor

Iragne commented Aug 21, 2024

@avelad i'm still seeing the issue in my main branch updated.
The issue for me is at the end of the live 2 events are trigger quite in the same time but the stat of the video element is already set to paused = true and ended = true.
So when updateStateHistory_ is trigger it's only switching to pause and never to ended

BTW test done on FF

I was working on a fix but i'm wondering what should be the correct approach
at the end of the stream

Option 1

  • Pause event => we should trigger it
  • End event => we should trigger it
    Option 2
  • Pause event => we skip it because the state of the video element is in ended = true state
  • End event => we should trigger it

@shaka-bot shaka-bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Aug 21, 2024
@avelad
Copy link
Member

avelad commented Aug 21, 2024

I tested with the streams provided by @zubcoco and the ended event is fired and isLive returns false. I used: https://nightly-dot-shaka-player-demo.appspot.com

@Iragne I think what you report is another problem, please make an issue with your problem, and with streams to reproduce it and I will look at it.

@avelad
Copy link
Member

avelad commented Aug 21, 2024

@Iragne Contact me via Slack (https://video-dev.slack.com/team/U05DB2BTVRU) and I will try to help you faster

@Iragne
Copy link
Contributor

Iragne commented Aug 21, 2024

@avelad It looks like there isn’t an account on XXX tied to this email address.

@avelad
Copy link
Member

avelad commented Aug 21, 2024

@Iragne #7189 :)

@avelad avelad closed this as completed in f6be619 Aug 21, 2024
avelad added a commit that referenced this issue Aug 22, 2024
avelad added a commit that referenced this issue Aug 22, 2024
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Oct 20, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Oct 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: DASH The issue involves the MPEG DASH manifest format priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants