-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot create a Shaka Player in Cobalt #6517
Labels
priority: P2
Smaller impact or easy workaround
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
Milestone
Comments
@MichaelSweden Please send you PR! I'll review it asap. Thanks! |
Maybe |
MichaelSweden
added a commit
to MichaelSweden/shaka-player
that referenced
this issue
Apr 30, 2024
Yes, navigator.platform doesn't exist in Cobalt browser. |
avelad
added a commit
that referenced
this issue
Apr 30, 2024
This fix will make it possible to use v4.8 in Cobalt browser. The problem is that navigator.platform doesn't exist in Cobalt browser. Fixes #6517 --------- Co-authored-by: Álvaro Velad Galván <[email protected]>
avelad
added a commit
that referenced
this issue
May 6, 2024
This fix will make it possible to use v4.8 in Cobalt browser. The problem is that navigator.platform doesn't exist in Cobalt browser. Fixes #6517 --------- Co-authored-by: Álvaro Velad Galván <[email protected]>
joeyparrish
pushed a commit
that referenced
this issue
May 7, 2024
This fix will make it possible to use v4.8 in Cobalt browser. The problem is that navigator.platform doesn't exist in Cobalt browser. Fixes #6517 --------- Co-authored-by: Álvaro Velad Galván <[email protected]>
joeyparrish
pushed a commit
that referenced
this issue
May 7, 2024
This fix will make it possible to use v4.8 in Cobalt browser. The problem is that navigator.platform doesn't exist in Cobalt browser. Fixes #6517 --------- Co-authored-by: Álvaro Velad Galván <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
priority: P2
Smaller impact or easy workaround
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
Have you read the FAQ and checked for duplicate open issues?
Yes
If the problem is related to FairPlay, have you read the tutorial?
Not related.
What version of Shaka Player are you using?
v4.8.1
Can you reproduce the issue with our latest release version?
Yes
Can you reproduce the issue with the latest code from
main
?Yes
Are you using the demo app or your own custom app?
Own html page.
If custom app, can you reproduce the issue using our demo app?
Cannot use your demo app, it's not compatible with Cobalt.
What browser and OS are you using?
Cobalt browser (main branch) and Xubuntu.
The problem doesn't appear with Firefox or Chromium
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
Not applicable.
What are the manifest and license server URIs?
Don't come so far.
What configuration are you using? What is the output of
player.getConfiguration()
?Default.
What did you do?
"var player = new shaka.Player(video)"
What did you expect to happen?
Get a shaka player object.
What actually happened?
Got an exception: "TypeError: Cannot read property 'toLowerCase' of undefined"
Can be derived to shaka.Player.constructor() -> shaka.util.PlayerConfiguration.createDefault() -> supportsSmoothCodecSwitching() -> isWindows()
I have a fix for it and can create a pull request.
The text was updated successfully, but these errors were encountered: