fix: Prevent license requests for unplayable variants #6204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: bug
littlespex
approved these changes
Jan 31, 2024
joeyparrish
reviewed
Jan 31, 2024
| this.onTracksChanged_(); | ||
| } | ||
|
|
||
| const playableVariants = shaka.util.StreamUtils.getPlayableVariants( |
There was a problem hiding this comment.
This removes any variant that is not allowedByKeySystem. In some cases, this may prevent license requests for streams that are only unplayable because we haven't made a license request.
There was a problem hiding this comment.
That's correct, but at this point no variant allowedByKeySystem = false has yet been set, so it will never filter allowedByKeySystem
avelad
added a commit
that referenced
this pull request
Feb 1, 2024
avelad
added a commit
that referenced
this pull request
Feb 1, 2024
theodab
added a commit
to theodab/shaka-player
that referenced
this pull request
Feb 1, 2024
joeyparrish
pushed a commit
that referenced
this pull request
Feb 17, 2024
Vasanthavanan-Devarajan
pushed a commit
to Vasanthavanan-Devarajan/shaka-player
that referenced
this pull request
Feb 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3429