-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should 'Restrictions' in Config prevent license requests for restricted adaptation sets? #3429
Comments
I'm going to mark this as an enhancement since, even though I haven't reproduced, I think you are correct. When a stream is restricted, we just mark it to not be played, but we probably still send all the license requests out. We could probably change this to check for whether it is restricted before sending out the license request. Can you provide some sample content for this? All out content uses a single PSSH data so we get all the keys with one license request. The content should last a while since this will be put on the backlog for now. |
I believe there is an important difference between |
Using the following in Custom Content on https://shaka-player-demo.appspot.com/demo Content: https://urm.latens.com:9443/content/pr3_altered/out.mpd (Note this is a long lasting token, however should it need replaced let me know). The content has the Playready PSSH containing WRM Header version PRHO 4.0.0.0. Setting restrictions.maxHeight=1080 prevents the 2160p resolution from being selected in the video pane, but it does NOT prevent a license request. |
Have you read the Tutorials?
Yes
Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
2.5.17
Please ask your question
If content is encoded with separate adaptation sets for Audio/SD/HD/UHD
SD has two representations 360p/480p protected with KeyId ‘a’ (for example)
HD has two representations 720p/1080p protected with KeyId ‘b’
UHD has one representation 2160p protected with KeyId ‘c’
Audio has one representation 128kbps protected with KeyId ‘d’
And the Player Config has been configured thus:
abr.restrictions.maxWidth=1920;abr.restrictions.maxHeight=1080;restrictions.maxWidth=1920;restrictions.maxHeight=1080
(omitted the rest of the URL)
Should Shaka still attempt to retrieve the UHD key?
Or just prevent the playback / selection of the 2160p adaptation set?
What I am seeing that whilst it does prevent the selection of the 2160p track, it still requests that key from the license server. I had hoped that it would prevent the license request for the UHD key. Note this is being tested with Playready using a PRHO version 4.0.0.0.
The text was updated successfully, but these errors were encountered: