Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text track roles are being incorrectly combined in certain multi-period cases #6054

Closed
littlespex opened this issue Jan 8, 2024 · 0 comments · Fixed by #6055 or #5987
Closed

Text track roles are being incorrectly combined in certain multi-period cases #6054

littlespex opened this issue Jan 8, 2024 · 0 comments · Fixed by #6055 or #5987
Assignees
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@littlespex
Copy link
Contributor

littlespex commented Jan 8, 2024

Have you read the FAQ and checked for duplicate open issues?
Yes

If the problem is related to FairPlay, have you read the tutorial?

N/A

What version of Shaka Player are you using?

4.6.6, 4.7.2

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from main?
Yes

Are you using the demo app or your own custom app?
Both

If custom app, can you reproduce the issue using our demo app?
Yes

What browser and OS are you using?
Chrome / MacOS

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
N/A

What are the manifest and license server URIs?

Sent separately

What configuration are you using? What is the output of player.getConfiguration()?

Default

What did you do?

  1. Load a multi-period manifest with multi language audio, text tracks, and forced subtitle tracks. One period must not contain the forced subtitle track/adaptation set.
  2. Call getTextTracks()

What did you expect to happen?
Each text track should have a single role, either 'subtitle' or 'forced-subtitle'.

What actually happened?

The text track roles are combined into resulting in one of the tracks having both 'subtitle' and 'forced-subtitle' roles.

@littlespex littlespex added the type: bug Something isn't working correctly label Jan 8, 2024
@littlespex littlespex self-assigned this Jan 8, 2024
@shaka-bot shaka-bot added this to the v5.0 milestone Jan 8, 2024
@littlespex littlespex changed the title Forced subtitle tracks are being combined with regular text track of the same language. Text track roles are being incorrectly combined in certain multi-period cases Jan 8, 2024
joeyparrish pushed a commit that referenced this issue Feb 17, 2024
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Mar 9, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Mar 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
2 participants