Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(UI): Add double tap to forward/rewind in the video #5943

Merged
merged 2 commits into from
Nov 29, 2023
Merged

feat(UI): Add double tap to forward/rewind in the video #5943

merged 2 commits into from
Nov 29, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Nov 28, 2023 •
edited
Loading

Closes #3357
Closes #3303

Thanks to @surajkumar-sk, his #3373 has been the inspiration for this.

@avelad avelad added type: enhancement New feature or request component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround labels Nov 28, 2023
@avelad avelad added this to the v5.0 milestone Nov 28, 2023
@shaka-bot
Copy link
Collaborator

shaka-bot commented Nov 28, 2023 •
edited
Loading

Incremental code coverage: 72.73%

theodab
theodab requested changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@theodab theodab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this out and it seems to work correctly.

ui/hidden_rewind_button.js Outdated Show resolved Hide resolved
@avelad avelad requested a review from theodab November 29, 2023 07:32
@avelad avelad merged commit 918c30b into shaka-project:main Nov 29, 2023
11 of 16 checks passed
@avelad avelad deleted the seek-on-taps branch November 29, 2023 09:23
@shaka-bot shaka-bot mentioned this pull request Nov 29, 2023
Merged
Robloche pushed a commit to Robloche/shaka-player that referenced this pull request Nov 30, 2023
@avelad
feat(UI): Add double tap to forward/rewind in the video (shaka-projec…
729d390 
…t#5943)

Closes shaka-project#3357
Closes shaka-project#3303

Thanks to @surajkumar-sk, his
shaka-project#3373 has been the
inspiration for this.
@soonoo
Copy link

soonoo commented Dec 14, 2023

singleClickForPlayAndPause is ignored on rewind and fast-forward container click. Is it possible to play or pause on single click?

@Bnyro Bnyro mentioned this pull request Jan 14, 2024
Closed
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jan 28, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jan 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@littlespex littlespex Awaiting requested review from littlespex

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

Double tap to forward/seek in the video Double-tap to seek on mobile
4 participants
@avelad @shaka-bot @soonoo @theodab