Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double-tap to seek on mobile #3303

Closed
aditmehta9 opened this issue Apr 1, 2021 · 19 comments · Fixed by #5943
Closed

Double-tap to seek on mobile #3303

aditmehta9 opened this issue Apr 1, 2021 · 19 comments · Fixed by #5943
Labels
component: UI The issue involves the Shaka Player UI flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone
v4.7

Comments

@aditmehta9
Copy link
Contributor

Have you read the FAQ and checked for duplicate open issues?
Yes

Describe the solution you'd like

There is a replay icon in the video element when viewed in the browser but not in mobile view so the replay icon can be added.
Addition of the feature like youtube in mobile which allows fast forward on double click on right side of the screen and rewinds on the left side of the screen.

Additional context
image
image
@michellezhuogg michellezhuogg added flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this component: UI The issue involves the Shaka Player UI and removed needs triage labels Apr 1, 2021
@aditmehta9
Copy link
Contributor Author

If someone wants to work on this issue for part one, one has to do a similar thing like this PR for big play button file.

@iprasandeep
Copy link

Hi, @aditmehta9 I want to work on this issue. Please assign me if it is open.

@aditmehta9
Copy link
Contributor Author

Hi, @aditmehta9 I want to work on this issue. Please assign me if it is open.

I can't assign only members can assign.

@iprasandeep
Copy link

then, @aditmehta9 how can I join as a member?

@aditmehta9
Copy link
Contributor Author

then, @aditmehta9 how can I join as a member?

Sorry, I meant only members can assign you we can't be a member.

@iprasandeep
Copy link

then, @aditmehta9 how can I join as a member?

Sorry, I meant only members can assign you we can't be a member.

Ooh!! sorry for the misunderstanding from my side.

@nbcl
Copy link
Contributor

nbcl commented Apr 12, 2021

Hello @prsndp!

Are you still working on a fix for this issue?

Please let me know if you need any help approaching the solution and I will be happy to help!

@iprasandeep
Copy link

HI @nbcl! Yeah, sure. I'm working on this issue.
There is any deadline for this?

@nbcl
Copy link
Contributor

nbcl commented Apr 12, 2021

There is any deadline for this?

As far as I understand, there should not be any because it is not currently assigned to any milestone or label!

HI @nbcl! Yeah, sure. I'm working on this issue.

Let me know if I can be of help!

@iprasandeep
Copy link

There is any deadline for this?

As far as I understand, there should not be any because it is not currently assigned to any milestone or label!

HI @nbcl! Yeah, sure. I'm working on this issue.

Let me know if I can be of help!

Yeah Sure!

@ismena
Copy link
Contributor

ismena commented Apr 13, 2021

You are correct, if the issue is not assigned to a milestone, there is no deadline.
@prsndp @nbcl I'm assigning you both per your interest.

@nbcl
Copy link
Contributor

nbcl commented Apr 13, 2021

Great!

@prsndp, feel free to create a pull request or draft with your updates whenever you feel ready, and I will make sure to check in and provide any feedback that could be useful if it was needed.

I can also provide feedback on your personal fork if you point me to a specific branch if that is what you prefer!

Let me know!

@iprasandeep
Copy link

Great!

@prsndp, feel free to create a pull request or draft with your updates whenever you feel ready, and I will make sure to check in and provide any feedback that could be useful if it was needed.

I can also provide feedback on your personal fork if you point me to a specific branch if that is what you prefer!

Let me know!

@nbcl Yeah Sure!

@joeyparrish joeyparrish added the type: enhancement New feature or request label Apr 13, 2021
@joeyparrish joeyparrish added this to the Backlog milestone Apr 13, 2021
@surajkumar-sk
Copy link
Contributor

surajkumar-sk commented Apr 30, 2021 •
edited
Loading

I didn't know this was the original issue and people are already assigned for it. Issue #3357 describes adding of fast-forward and rewind buttons on double click and no one was working on it , so I started the work and added a PR #3373 . I am extremely sorry assignees if you were working on it, well the PR has not been reviewed yet so it can be rejected by reviewers.

@nbcl
Copy link
Contributor

nbcl commented Apr 30, 2021

@surajkumar-sk you are right, #3357 contains a duplicate of the second enhancement request that is present in this issue.

Personally, as I agreed in a couple of messages before, I was supposed not to directly code the solution, but to check in and provide any feedback that could be useful if it was needed - This being the case, and as you already brought together a pull request, then I can take my efforts to provide feedback on #3373 as soon as I am able to.

Now, apart from that, and with the objective of keeping the issues in a correct manner, this issue could be re purposed to only consider the first enhancement:

"There is a replay icon in the video element when viewed in the browser but not in mobile view so the replay icon can be added."

This way we leave the second request, "fast-forward buttons on double tap" to be specifically considered in #3357.

@prsndp @surajkumar-sk, do you agree with this new arrangement?

Please let me know!

@surajkumar-sk
Copy link
Contributor

surajkumar-sk commented Apr 30, 2021 •
edited
Loading

@nbcl An appreciation for you english . You are really good at writing formal messages .

As per the first issue . The changes will be pretty small, a few lines. After review, if the changes are good, I can fix the first issue too in the same pr. 🙂

@nbcl
Copy link
Contributor

nbcl commented Apr 30, 2021 •
edited
Loading

An appreciation for you english . You are really good at writing formal messages .

I always try to take an extra minute to check if I am being clear in my responses, so I really appreciate your message!

I have always though that when building software, specially open source, communication plays one of the most important parts in the success of a project. I always tell my friends that, of course, there is no software without code, but can a team really build something great without communicating accordingly?

As per the first issue . The changes will be pretty small, a few lines. After review, if the changes are good, I can fix the first issue too in the same pr. 🙂

Sounds great - Let's maybe wait a bit for @prsndp to comment before continuing with the first enhancement!

@surajkumar-sk
Copy link
Contributor

@nbcl this is probably a low priority issue right now for members, with the gsoc and 3.1.0 release members are pretty busy. I don't expect a review for atleast a week from now . We got a lot of time to continue this discussion .

@nbcl
Copy link
Contributor

nbcl commented Apr 30, 2021

Definitely, sounds good! - That being the case we can await a response and, in the meanwhile, I will try to reach out with a review on #3373 in the upcoming weekend! 😄

@joeyparrish joeyparrish changed the title Enhancements for mobile view Double-tap to seek on mobile Oct 4, 2021
@joeyparrish joeyparrish added the priority: P3 Useful but not urgent label Oct 4, 2021
@Mennaruuk Mennaruuk mentioned this issue Mar 19, 2022
Closed
@avelad avelad mentioned this issue Nov 28, 2023
Merged
avelad added a commit that referenced this issue Nov 29, 2023
@avelad
feat(UI): Add double tap to forward/rewind in the video (#5943)
918c30b 
Closes #3357
Closes #3303

Thanks to @surajkumar-sk, his
#3373 has been the
inspiration for this.
@avelad avelad modified the milestones: Backlog, v4.7 Nov 30, 2023
Robloche pushed a commit to Robloche/shaka-player that referenced this issue Nov 30, 2023
@avelad
feat(UI): Add double tap to forward/rewind in the video (shaka-projec…
729d390 
…t#5943)

Closes shaka-project#3357
Closes shaka-project#3303

Thanks to @surajkumar-sk, his
shaka-project#3373 has been the
inspiration for this.
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jan 28, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jan 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: UI The issue involves the Shaka Player UI flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.7
Development

Successfully merging a pull request may close this issue.

feat(UI): Add double tap to forward/rewind in the video avelad/shaka-player
9 participants
@ismena @joeyparrish @avelad @shaka-bot @michellezhuogg @aditmehta9 @nbcl @iprasandeep @surajkumar-sk