Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Demo): Allow configure some missing configs #5918

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Nov 22, 2023

No description provided.

@avelad avelad added type: bug Something isn't working correctly component: demo page The issue is in the demo page; does not affect production applications priority: P2 Smaller impact or easy workaround labels Nov 22, 2023
@avelad avelad added this to the v5.0 milestone Nov 22, 2023
@shaka-bot
Copy link
Collaborator

Incremental code coverage: No instrumented code was changed.

@avelad avelad merged commit c62e38c into shaka-project:main Nov 22, 2023
@avelad avelad deleted the demo-config branch November 22, 2023 14:08
Robloche pushed a commit to Robloche/shaka-player that referenced this pull request Nov 30, 2023
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jan 21, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: demo page The issue is in the demo page; does not affect production applications priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants