Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hls playback is not recover after internet connection is restored #5873

Closed
Able1991 opened this issue Nov 8, 2023 · 3 comments · Fixed by #5879
Closed

Hls playback is not recover after internet connection is restored #5873

Able1991 opened this issue Nov 8, 2023 · 3 comments · Fixed by #5879
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v4.6

Comments

@Able1991
Copy link

Able1991 commented Nov 8, 2023

What version of Shaka Player are you using?
v4.5.0-uncompiled

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from main?
Yes

Are you using the demo app or your own custom app?
The demo

If custom app, can you reproduce the issue using our demo app?
N/A

What browser and OS are you using?
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/119.0.0.0 Safari/537.36

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
N/A

What are the manifest and license server URIs?

uri= https://cph-p2p-msl.akamaized.net/hls/live/2000341/test/master.m3u8

What configuration are you using? What is the output of player.getConfiguration()?

{
    "manifest": {
        "hls": {
            "sequenceMode": false
        }
    }
}

What did you do?

Set throttling to offline in Chrome dev tools for 15 seconds, and then disable it

What did you expect to happen?
Restore playback

What actually happened?
Nothing, the player spins the loader

image
@avelad
Copy link
Member

avelad commented Nov 9, 2023

@theodab can you review it? Thanks!

@avelad avelad added type: bug Something isn't working correctly component: HLS The issue involves Apple's HLS manifest format labels Nov 9, 2023
@shaka-bot shaka-bot added this to the v4.6 milestone Nov 9, 2023
@avelad avelad added the priority: P1 Big impact or workaround impractical; resolve before feature release label Nov 13, 2023
@avelad
Copy link
Member

avelad commented Nov 13, 2023

I can reproduce the error

@avelad
Copy link
Member

avelad commented Nov 13, 2023

Only occurs with live HLS streams

@avelad avelad mentioned this issue Nov 13, 2023
Merged
avelad added a commit that referenced this issue Nov 13, 2023
@avelad
fix(ABR): Fix HLS playback after internet connection is restored (#5879)
f5777e5 
Fixes #5873
Robloche pushed a commit to Robloche/shaka-player that referenced this issue Nov 30, 2023
@avelad
fix(ABR): Fix HLS playback after internet connection is restored (sha…
66c4cac 
…ka-project#5879)

Fixes shaka-project#5873
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jan 12, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jan 12, 2024
joeyparrish pushed a commit that referenced this issue Feb 17, 2024
@avelad @joeyparrish
fix(ABR): Fix HLS playback after internet connection is restored (#5879)
65d1157 
Fixes #5873

Backported to v4.3.x
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.6
Development

Successfully merging a pull request may close this issue.

fix(ABR): Fix HLS playback after internet connection is restored avelad/shaka-player
3 participants
@Able1991 @avelad @shaka-bot