Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(HLS): Add support for QUERYPARAM variable type in #EXT-X-DEFINE #5801

Merged
merged 2 commits into from
Oct 24, 2023
Merged

feat(HLS): Add support for QUERYPARAM variable type in #EXT-X-DEFINE #5801

merged 2 commits into from
Oct 24, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Oct 24, 2023

Closes #5333

@avelad avelad added this to the v4.6 milestone Oct 24, 2023
@avelad avelad added type: enhancement New feature or request component: HLS The issue involves Apple's HLS manifest format priority: P3 Useful but not urgent labels Oct 24, 2023
@avelad avelad force-pushed the hls-variable-queryparam branch from ee24e82 to 1fc3745 Compare October 24, 2023 10:38
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad requested a review from littlespex October 24, 2023 16:48
@avelad avelad merged commit fda3189 into shaka-project:main Oct 24, 2023
16 checks passed
@shaka-bot shaka-bot mentioned this pull request Oct 24, 2023
Merged
@avelad avelad deleted the hls-variable-queryparam branch October 25, 2023 07:16
Robloche pushed a commit to Robloche/shaka-player that referenced this pull request Nov 30, 2023
@avelad
feat(HLS): Add support for QUERYPARAM variable type in #EXT-X-DEFINE (s…
265cc9d 
…haka-project#5801)

Closes shaka-project#5333
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Dec 23, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Dec 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@littlespex littlespex littlespex approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

HLS: Add support for QUERYPARAM variable type in #EXT-X-DEFINE
3 participants
@avelad @shaka-bot @littlespex