Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLS: Add support for QUERYPARAM variable type in #EXT-X-DEFINE #5333

Closed
duggaraju opened this issue Jun 20, 2023 · 2 comments · Fixed by #5801
Closed

HLS: Add support for QUERYPARAM variable type in #EXT-X-DEFINE #5333

duggaraju opened this issue Jun 20, 2023 · 2 comments · Fixed by #5801
Assignees
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone

Comments

@duggaraju
Copy link
Contributor

Have you read the FAQ and checked for duplicate open issues?
YEs

Is your feature request related to a problem? Please describe.

This is just the gap with the latest HLS spec.

Describe the solution you'd like

Per HLS spec: https://datatracker.ietf.org/doc/html/draft-pantos-hls-rfc8216bis#section-4.4.2.3
QUERYPARAM

  The value is a quoted-string which specifies the Variable Name and
  indicates that its value is the value associated with the query
  parameter of the same name in the URI of the Playlist.  The valid
  character set for the quoted-string is the same as for the NAME
  attribute.  The value associated with the query parameter MUST be
  percent-decoded before performing the variable replacement.  The
  decoded value MUST NOT contain any of the characters disallowed in
  quoted-strings.

  If the QUERYPARAM attribute value does not match any query
  parameter in the URI or the matching parameter has no associated
  value, the parser MUST fail to parse the Playlist.  If more than
  one parameter matches, any of the associated values MAY be used.

  If the URI is redirected, the client MUST look for the query
  parameter in the 30x response URI.

Describe alternatives you've considered

Alternative would be writing a network plugin which will not work with native iOS playback.

Additional context

Requring a query string with token for authentication when playing HLS . However for native playback (iOS) you would need to update manifest and either use a variable or rewrite the URLs. With the queryparam approach you can substitute the variable outside with a query parameter.

@duggaraju duggaraju added the type: enhancement New feature or request label Jun 20, 2023
@github-actions github-actions bot added this to the Backlog milestone Jun 20, 2023
@avelad avelad added component: HLS The issue involves Apple's HLS manifest format priority: P3 Useful but not urgent labels Jun 21, 2023
@avelad
Copy link
Member

avelad commented Jun 21, 2023

@duggaraju are you interested in send a PR for it?

@avelad avelad added the flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this label Jun 26, 2023
@avelad avelad removed the flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this label Oct 23, 2023
@avelad
Copy link
Member

avelad commented Oct 23, 2023

I'll work on this in a few days

@avelad avelad self-assigned this Oct 23, 2023
@avelad avelad modified the milestones: Backlog, v4.6 Oct 24, 2023
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Dec 23, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Dec 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants