Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix TS transmuxer when the main content is muxed #5575

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Sep 1, 2023

Fixes #5572

The main problem is that the content has audio and video muxed and then has the alternative audio tracks.

We need to detect that the main content is muxed and only extract the video.

Test stream: https://ztnr.rtve.es/ztnr/1694255.m3u8

@avelad avelad added type: bug Something isn't working correctly component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release labels Sep 1, 2023
@avelad avelad added this to the v4.5 milestone Sep 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Incremental code coverage: 66.67%

@avelad avelad merged commit 65b3037 into shaka-project:main Sep 1, 2023
@avelad avelad deleted the fix-ts-transmuxer branch September 1, 2023 15:20
joeyparrish pushed a commit to joeyparrish/shaka-player that referenced this pull request Sep 1, 2023
…5575)

Fixes shaka-project#5572

The main problem is that the content has audio and video muxed and then
has the alternative audio tracks.

We need to detect that the main content is muxed and only extract the
video.

Test stream: https://ztnr.rtve.es/ztnr/1694255.m3u8
joeyparrish pushed a commit that referenced this pull request Sep 2, 2023
Fixes #5572

The main problem is that the content has audio and video muxed and then
has the alternative audio tracks.

We need to detect that the main content is muxed and only extract the
video.

Test stream: https://ztnr.rtve.es/ztnr/1694255.m3u8
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Oct 31, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playout fails: CHUNK_DEMUXER_ERROR_APPEND_FAILED
3 participants