Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chrome + HLS subtitles not visible. #5355

Closed
bidisha15hotstar opened this issue Jun 26, 2023 · 2 comments · Fixed by #5357
Closed

Chrome + HLS subtitles not visible. #5355

bidisha15hotstar opened this issue Jun 26, 2023 · 2 comments · Fixed by #5357
Assignees
@bidisha15hotstar
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v4.4

Comments

@bidisha15hotstar
Copy link

Have you read the FAQ and checked for duplicate open issues?

What version of Shaka Player are you using?
3.3.x

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from main?
Yes

Are you using the demo app or your own custom app?
Custom App

If custom app, can you reproduce the issue using our demo app?
Yes

What browser and OS are you using?
Mac 13.3.1 Chromr

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?

What configuration are you using? What is the output of player.getConfiguration()?

What did you do?

  1. Try to run any Chrome + Hls content on old movies it doesn't show subtitles

What did you expect to happen?

  1. Subtitles should be shown

What actually happened?

hotstarissue
@bidisha15hotstar bidisha15hotstar added the type: bug Something isn't working correctly label Jun 26, 2023
@avelad
Copy link
Member

avelad commented Jun 26, 2023

@bidisha15hotstar can you provide the manifest uri? Thanks!

@avelad avelad added status: waiting on response Waiting on a response from the reporter(s) of the issue component: HLS The issue involves Apple's HLS manifest format labels Jun 26, 2023
@github-actions github-actions bot added this to the v4.4 milestone Jun 26, 2023
@bidisha15hotstar
Copy link
Author

https://hsprepack.akamaized.net/videos/movies/hindi/1000007131/master.m3u8?hdnea=st=1687780484~exp=1687781084~acl=/videos/movies/hindi/1000007131/*~data=ip=o5RhgRgp6Cpc22SulvmTkg-userid=Usw4bheq67fBAxDzaZmPCucARhJQyISOFSba7fUwF6Ux-did=16U2G41TsXw35C4ra0WAs2G1tPIRPaitE7CCAfieFQfI-cc=in-~hmac=a0026e67031754a5f6663fefebc2dfcaf95cbbcb4306d80dcccf61b78eaf983a

Response:
#EXTM3U
#EXT-X-VERSION:4
#EXT-X-MEDIA:TYPE=SUBTITLES,GROUP-ID="subtitles",NAME="English",AUTOSELECT=YES,DEFAULT=YES,LANGUAGE="en",URI="master_subtitle.m3u8"
#EXT-X-INDEPENDENT-SEGMENTS
#EXT-X-STREAM-INF:BANDWIDTH=119944,AVERAGE-BANDWIDTH=98111,CODECS="avc1.42c015,mp4a.40.5",RESOLUTION=250x140,SUBTITLES="subtitles",FRAME-RATE=25.000
master_Layer1.m3u8
#EXT-X-I-FRAME-STREAM-INF:BANDWIDTH=59972,AVERAGE-BANDWIDTH=49055,CODECS="avc1.42c015",RESOLUTION=250x140,URI="master_Layer1_I-Frame.m3u8",SUBTITLES="subtitles"
#EXT-X-STREAM-INF:BANDWIDTH=191008,AVERAGE-BANDWIDTH=149786,CODECS="avc1.42c015,mp4a.40.5",RESOLUTION=320x180,SUBTITLES="subtitles",FRAME-RATE=25.000
master_Layer2.m3u8
#EXT-X-I-FRAME-STREAM-INF:BANDWIDTH=95504,AVERAGE-BANDWIDTH=74893,CODECS="avc1.42c015",RESOLUTION=320x180,URI="master_Layer2_I-Frame.m3u8",SUBTITLES="subtitles"
#EXT-X-STREAM-INF:BANDWIDTH=355320,AVERAGE-BANDWIDTH=270902,CODECS="avc1.42c015,mp4a.40.2",RESOLUTION=320x180,SUBTITLES="subtitles",FRAME-RATE=25.000
master_Layer3.m3u8
#EXT-X-I-FRAME-STREAM-INF:BANDWIDTH=177660,AVERAGE-BANDWIDTH=135451,CODECS="avc1.42c015",RESOLUTION=320x180,URI="master_Layer3_I-Frame.m3u8",SUBTITLES="subtitles"
#EXT-X-STREAM-INF:BANDWIDTH=674168,AVERAGE-BANDWIDTH=451867,CODECS="avc1.42c01e,mp4a.40.2",RESOLUTION=416x234,SUBTITLES="subtitles",FRAME-RATE=25.000
master_Layer4.m3u8
#EXT-X-I-FRAME-STREAM-INF:BANDWIDTH=337084,AVERAGE-BANDWIDTH=225933,CODECS="avc1.42c01e",RESOLUTION=416x234,URI="master_Layer4_I-Frame.m3u8",SUBTITLES="subtitles"
#EXT-X-STREAM-INF:BANDWIDTH=1178384,AVERAGE-BANDWIDTH=542010,CODECS="avc1.42c01e,mp4a.40.2",RESOLUTION=640x360,SUBTITLES="subtitles",FRAME-RATE=25.000
master_Layer5.m3u8
#EXT-X-I-FRAME-STREAM-INF:BANDWIDTH=589192,AVERAGE-BANDWIDTH=271005,CODECS="avc1.42c01e",RESOLUTION=640x360,URI="master_Layer5_I-Frame.m3u8",SUBTITLES="subtitles"
#EXT-X-STREAM-INF:BANDWIDTH=1814952,AVERAGE-BANDWIDTH=684953,CODECS="avc1.42c01e,mp4a.40.2",RESOLUTION=720x404,SUBTITLES="subtitles",FRAME-RATE=25.000
master_Layer6.m3u8
#EXT-X-I-FRAME-STREAM-INF:BANDWIDTH=907476,AVERAGE-BANDWIDTH=342476,CODECS="avc1.42c01e",RESOLUTION=720x404,URI="master_Layer6_I-Frame.m3u8",SUBTITLES="subtitles"
#EXT-X-STREAM-INF:BANDWIDTH=2826768,AVERAGE-BANDWIDTH=1251413,CODECS="avc1.4d401f,mp4a.40.2",RESOLUTION=1280x720,SUBTITLES="subtitles",FRAME-RATE=25.000
master_Layer7.m3u8
#EXT-X-I-FRAME-STREAM-INF:BANDWIDTH=1413384,AVERAGE-BANDWIDTH=625706,CODECS="avc1.4d401f",RESOLUTION=1280x720,URI="master_Layer7_I-Frame.m3u8",SUBTITLES="subtitles"
#EXT-X-STREAM-INF:BANDWIDTH=4324376,AVERAGE-BANDWIDTH=1779451,CODECS="avc1.4d4028,mp4a.40.2",RESOLUTION=1600x900,SUBTITLES="subtitles",FRAME-RATE=25.000
master_Layer8.m3u8
#EXT-X-I-FRAME-STREAM-INF:BANDWIDTH=2162188,AVERAGE-BANDWIDTH=889725,CODECS="avc1.4d4028",RESOLUTION=1600x900,URI="master_Layer8_I-Frame.m3u8",SUBTITLES="subtitles"
#EXT-X-STREAM-INF:BANDWIDTH=5974264,AVERAGE-BANDWIDTH=2469502,CODECS="avc1.4d4028,mp4a.40.2",RESOLUTION=1920x1080,SUBTITLES="subtitles",FRAME-RATE=25.000
master_Layer9.m3u8
#EXT-X-I-FRAME-STREAM-INF:BANDWIDTH=2987132,AVERAGE-BANDWIDTH=1234751,CODECS="avc1.4d4028",RESOLUTION=1920x1080,URI="master_Layer9_I-Frame.m3u8",SUBTITLES="subtitles"

@github-actions github-actions bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Jun 26, 2023
@avelad avelad mentioned this issue Jun 26, 2023
Merged
@joeyparrish joeyparrish added the priority: P2 Smaller impact or easy workaround label Jul 19, 2023
joeyparrish added a commit that referenced this issue Jul 19, 2023
@officialbidisha @joeyparrish
fix(HLS): Add subtitle role when there are no roles (#5357)
7de6340 
Fixes #5355

Co-authored-by: Joey Parrish <[email protected]>
@github-actions github-actions bot mentioned this issue Jul 19, 2023
Merged
joeyparrish added a commit that referenced this issue Jul 20, 2023
@officialbidisha @joeyparrish
fix(HLS): Add subtitle role when there are no roles (#5357)
49e3734 
Fixes #5355

Backported to v4.3.x

Co-authored-by: Joey Parrish <[email protected]>
joeyparrish added a commit that referenced this issue Jul 20, 2023
@officialbidisha @joeyparrish
fix(HLS): Add subtitle role when there are no roles (#5357)
c5a5ddb 
Fixes #5355

Backported to v4.2.x

Co-authored-by: Joey Parrish <[email protected]>
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Sep 17, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Sep 17, 2023
Robloche pushed a commit to Robloche/shaka-player that referenced this issue Nov 30, 2023
@officialbidisha @joeyparrish
fix(HLS): Add subtitle role when there are no roles (shaka-project#5357)
246f7c5 
Fixes shaka-project#5355

Co-authored-by: Joey Parrish <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bidisha15hotstar bidisha15hotstar

Labels
component: HLS The issue involves Apple's HLS manifest format priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.4
Development

Successfully merging a pull request may close this issue.

fix(HLS): Add subtitle role when there are no roles officialbidisha/shaka-player
4 participants
@joeyparrish @avelad @shaka-bot @bidisha15hotstar