Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(HLS): Don't do sequence mode workaround unless there's a text stream #5315

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Jun 15, 2023

Fixes: #4975
Related to #5079 and #5108

@avelad avelad added type: bug Something isn't working correctly component: HLS The issue involves Apple's HLS manifest format priority: P2 Smaller impact or easy workaround labels Jun 15, 2023
@avelad avelad added this to the v4.4 milestone Jun 15, 2023
@github-actions
Copy link
Contributor

Incremental code coverage: 100.00%

@avelad
Copy link
Member Author

avelad commented Jun 15, 2023

Note: this will allow more optimizations in the media source in the future

@avelad avelad merged commit 019dcfd into shaka-project:main Jun 16, 2023
@avelad avelad deleted the sequencemodefix branch June 17, 2023 16:16
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Aug 15, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Choppy HLS MPEG-2 TS VOD playback with some gap jumping
2 participants