Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improve parsing time in DASH and HLS #5261

Merged
merged 2 commits into from
Jun 7, 2023
Merged

feat: Improve parsing time in DASH and HLS #5261

merged 2 commits into from
Jun 7, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Jun 6, 2023

This PR improve the parsing time for DASH and HLS changing when the uris of the segments are constructed. Now the uris are constructed on demand.

@avelad avelad added type: enhancement New feature or request component: HLS The issue involves Apple's HLS manifest format priority: P3 Useful but not urgent component: DASH The issue involves the MPEG DASH manifest format labels Jun 6, 2023
@avelad avelad added this to the v4.4 milestone Jun 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

Incremental code coverage: 100.00%

theodab
theodab requested changes Jun 7, 2023
View reviewed changes
lib/dash/segment_list.js Show resolved Hide resolved
lib/hls/hls_parser.js Outdated Show resolved Hide resolved
lib/hls/hls_parser.js Outdated Show resolved Hide resolved
@avelad avelad requested a review from theodab June 7, 2023 06:30
@avelad avelad merged commit f1e35fd into shaka-project:main Jun 7, 2023
@github-actions github-actions bot mentioned this pull request Jun 7, 2023
Merged
@avelad avelad mentioned this pull request Jun 7, 2023
Merged
@avelad avelad deleted the improve-parsing-time branch June 7, 2023 09:39
@OrenMe
Copy link
Contributor

OrenMe commented Jun 8, 2023

Hi @avelad, is there some benchmark of this improvement?

@avelad
Copy link
Member Author

avelad commented Jun 8, 2023

@OrenMe This PR together with #5264, in Tizen 3.0 with a HLS playlist of 8000 segments, the parsing time goes from 250ms to 70ms. It is a great improvement.

@OrenMe
Copy link
Contributor

OrenMe commented Jun 8, 2023

@avelad this is amazing, thanks for that!
For live playback on that version each time we get a live ma first refresh for a long dvr window stream we see GC goes crazy.
We tested the previous PR and so small change but we will now test with this one as well.
When is this due? We are waiting for both in 4.4.0

@avelad
Copy link
Member Author

avelad commented Jun 8, 2023

This change it's expected for 4.4, about the ETA... @joeyparrish ?

avelad added a commit that referenced this pull request Jun 8, 2023
@avelad
feat(HLS): Improve HLS parsing time (#5264)
2ca7d0b 
Related to #5261

This PR delays the creation of the final urls of the segments so that
they are not calculated in each media playlist parsing.
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Aug 6, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@littlespex littlespex Awaiting requested review from littlespex

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
component: DASH The issue involves the MPEG DASH manifest format component: HLS The issue involves Apple's HLS manifest format priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@avelad @OrenMe @theodab