Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support .tsa and .tsv file extensions when parsing MPEG2-TS manifests #5033

Closed
JulianDomingo opened this issue Feb 27, 2023 · 0 comments · Fixed by #5034
Closed

Support .tsa and .tsv file extensions when parsing MPEG2-TS manifests #5033

JulianDomingo opened this issue Feb 27, 2023 · 0 comments · Fixed by #5034
Assignees
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@JulianDomingo
Copy link
Contributor

Have you read the FAQ and checked for duplicate open issues?
Yes.

What version of Shaka Player are you using?
Latest (4.3.4).

Can you reproduce the issue with our latest release version?
Yes.

Can you reproduce the issue with the latest code from main?
Yes.

Are you using the demo app or your own custom app?
Custom app.

If custom app, can you reproduce the issue using our demo app?
Yes.

What browser and OS are you using?
Chrome, 1.52.

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
Google Nest Hub, 1.52.

What are the manifest and license server URIs?

https://frumos01.tivo.com/rolling-buffer/cnnhd/cnnhd/transmux/index.m3u8?ccur_fmt_type=ts

What configuration are you using? What is the output of player.getConfiguration()?

Default config.

What did you do?

  1. Load above URL.
  2. Content doesn't load successfully because the addSourceBuffer() call is passed an invalid mimetype (audio/MP2T). audio/MP2T is generated by the guessMimeType*() logic in HlsParser.

What did you expect to happen?

  1. Load above URL.
  2. Content loads successfully and creates a source buffer with the video/mp2t codecs.

What actually happened?

Shaka doesn't recognize the .tsa and .tsv file extensions as valid MPEG2-TS. However, these are valid: https://en.wikipedia.org/wiki/MPEG_transport_stream.

@JulianDomingo JulianDomingo added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release labels Feb 27, 2023
@JulianDomingo JulianDomingo added this to the v4.4 milestone Feb 27, 2023
@JulianDomingo JulianDomingo self-assigned this Feb 27, 2023
@avelad avelad changed the title Supoport .tsa and .tsv file extensions when parsing MPEG2-TS manifests Support .tsa and .tsv file extensions when parsing MPEG2-TS manifests Feb 27, 2023
@avelad avelad added the component: HLS The issue involves Apple's HLS manifest format label Feb 27, 2023
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Apr 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants