-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternate Audio Language ShakaUI #5019
Comments
Could this be a bug? |
The player API lets you see both languages and roles, and to select by language and role together if you wish. The UI is configurable to show roles IIRC. Let me find the config for you. |
Here it is. Configure the UI's
Quoting the docs:
Here's a snippet, assuming video.ui.configure(
'trackLabelFormat',
shaka.ui.Overlay.TrackLabelFormat.LANGUAGE_ROLE); |
That is great thank you for that information @joeyparrish ! |
@joeyparrish Is there a reason shaka uses the non-standard |
Shaka supports both forms. See https://github.com/shaka-project/shaka-player/blob/main/lib/dash/dash_parser.js#L1114-L1125 |
@avelad Would probably be a good idea to update the docs to say that, as they currently only say that it supports the non-standard label attribute. |
@absidue Can you tell me where you have seen it? I'll try to do a PR to fix it. |
In the description for the
https://shaka-player-demo.appspot.com/docs/api/shaka.extern.html#.UIConfiguration |
Have you read the Tutorials?
Yes
Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
4.3.4
Please ask your question
I have a manifest with multiple audio of the same Language.
The Audio is Alternate Audio Described.
The current Shaka UI displays the Language of
English
for bothThe markup for the manifest is as follows
My question is should I expect this to use the label property so that the user can distinguish between the Alternative Audio track?
The text was updated successfully, but these errors were encountered: