Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternate Audio Language ShakaUI #5019

Closed
stuartflanagan opened this issue Feb 21, 2023 · 9 comments · Fixed by #5518
Closed

Alternate Audio Language ShakaUI #5019

stuartflanagan opened this issue Feb 21, 2023 · 9 comments · Fixed by #5518
Labels
status: archived Archived and locked; will not be updated type: question A question from the community

Comments

@stuartflanagan
Copy link

Have you read the Tutorials?
Yes

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
4.3.4

Please ask your question
I have a manifest with multiple audio of the same Language.

The Audio is Alternate Audio Described.
The current Shaka UI displays the Language of English for both

The markup for the manifest is as follows

 <AdaptationSet mimeType="audio/mp4" startWithSAP="1" segmentAlignment="true" lang="en" label="English Audio Description" subsegmentAlignment="true" subsegmentStartsWithSAP="1">
      <Role schemeIdUri="urn:mpeg:dash:role:2011" value="alternate"/>
      <Accessibility schemeIdUri="urn:tva:metadata:cs:AudioPurposeCS:2007" value="1"/>
      <!-- MPEG Common Encryption -->
...
</AdaptationSet>

My question is should I expect this to use the label property so that the user can distinguish between the Alternative Audio track?

@stuartflanagan stuartflanagan added the type: question A question from the community label Feb 21, 2023
@stuartflanagan
Copy link
Author

Could this be a bug?

@joeyparrish
Copy link
Member

The player API lets you see both languages and roles, and to select by language and role together if you wish. The UI is configurable to show roles IIRC. Let me find the config for you.

@joeyparrish
Copy link
Member

Here it is. Configure the UI's trackLabelFormat field:

Quoting the docs:

field type description
trackLabelFormat shaka.ui.Overlay.TrackLabelFormat An enum that determines what is shown in the labels for text track and audio variant selection. LANGUAGE means that only the language of the item is shown. ROLE means that only the role of the item is shown. LANGUAGE_ROLE means both language and role are shown, or just language if there is no role. LABEL means the non-standard DASH "label" attribute or the HLS "NAME" attribute are shown. Defaults to LANGUAGE.

Here's a snippet, assuming video is a reference to your video element:

video.ui.configure(
    'trackLabelFormat',
    shaka.ui.Overlay.TrackLabelFormat.LANGUAGE_ROLE);

@stuartflanagan
Copy link
Author

That is great thank you for that information @joeyparrish !

@absidue
Copy link

absidue commented May 6, 2023

@joeyparrish Is there a reason shaka uses the non-standard label attribute instead of the Label element that is in the DASH specification (Section 5.3.10)?
Link to the specification: https://standards.iso.org/ittf/PubliclyAvailableStandards/c083314_ISO_IEC%2023009-1_2022(en).zip

@avelad
Copy link
Member

avelad commented Aug 22, 2023

@avelad avelad added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Aug 22, 2023
@absidue
Copy link

absidue commented Aug 22, 2023

@avelad Would probably be a good idea to update the docs to say that, as they currently only say that it supports the non-standard label attribute.

@avelad
Copy link
Member

avelad commented Aug 22, 2023

@absidue Can you tell me where you have seen it? I'll try to do a PR to fix it.

@github-actions github-actions bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Aug 22, 2023
@avelad avelad added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Aug 22, 2023
@absidue
Copy link

absidue commented Aug 22, 2023

In the description for the trackLabelFormat option in the UIConfiguration interface:

[...] LABEL means the non-standard DASH "label" attribute or the HLS "NAME" attribute are shown. [...]

https://shaka-player-demo.appspot.com/docs/api/shaka.extern.html#.UIConfiguration

avelad added a commit that referenced this issue Aug 22, 2023
@github-actions github-actions bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Aug 22, 2023
joeyparrish pushed a commit that referenced this issue Aug 30, 2023
joeyparrish pushed a commit that referenced this issue Aug 30, 2023
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Oct 21, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Oct 21, 2023
Robloche pushed a commit to Robloche/shaka-player that referenced this issue Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: question A question from the community
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants