fix: Fallback to isTypeSupported when cast namespace is undefined #5012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Incremental code coverage: 100.00% |
avelad
added
type: bug
|
@littlespex is it ready for review? |
|
I'm waiting on verification on a few other devices. I will pull it out of draft later today. |
|
@avelad Verification is complete and the PR is ready for review. |
avelad
approved these changes
Feb 22, 2023
|
@JulianDomingo, can you review it?, if I remember correctly you implemented this part. |
|
LGTM, but I would like Julian to confirm. I'll do a test run in the lab to be certain it doesn't break existing test cases. |
JulianDomingo
approved these changes
Feb 28, 2023
joeyparrish
pushed a commit
that referenced
this pull request
Mar 1, 2023
) Resolves #5010 --------- Co-authored-by: Dan Sparacio <[email protected]>
joeyparrish
pushed a commit
that referenced
this pull request
Mar 1, 2023
) Resolves #5010 --------- Co-authored-by: Dan Sparacio <[email protected]>
joeyparrish
pushed a commit
that referenced
this pull request
Mar 1, 2023
) Resolves #5010 --------- Co-authored-by: Dan Sparacio <[email protected]>
joeyparrish
pushed a commit
that referenced
this pull request
Mar 2, 2023
) Resolves #5010 --------- Co-authored-by: Dan Sparacio <[email protected]>
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5010