Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIZIO SmartCast TV is being incorrectly categorized as a Chromecast, breaking DRM playback #5010

Closed
littlespex opened this issue Feb 17, 2023 · 2 comments · Fixed by #5012
Closed
Labels
platform: TV/STB Issues affecting smart TV or set-top box platforms priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@littlespex
Copy link
Contributor

littlespex commented Feb 17, 2023

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
4.3.x

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from main?
Yes

Are you using the demo app or your own custom app?
Both

If custom app, can you reproduce the issue using our demo app?
Yes

What browser and OS are you using?
VIZIO TV

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
Mozilla/5.0 (X11; Linux armv7l) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/72.0.3626.121 Safari/537.36 CrKey/1.0.999999 VIZIO SmartCast(Conjure/SX7A-4.6.419.12 FW/11.0.120.1-1 Model/M65-D0)

What are the manifest and license server URIs?

Available upon request

What configuration are you using? What is the output of player.getConfiguration()?

Default

What did you do?

Configure a player to play DRM protected content on a VIZIO SmartCast TV.

What did you expect to happen?
Video should play.

What actually happened?

Player throws an 8000 error.

219510466-7ff35810-08de-4f4b-8b4c-f826f1f075c6

@littlespex littlespex added the type: bug Something isn't working correctly label Feb 17, 2023
@littlespex
Copy link
Contributor Author

littlespex commented Feb 17, 2023

@joeyparrish I'm not sure which approach is best to take for this fix:

  1. Refine the shaka.util.Platform.isChromecast() utility to ignore the VIZIO use case. I'm not sure if this would break scenarios where the TV was acting specifically as a cast device. Maybe have the utility check for CrKey in the user agent and the existence of window.cast?
  2. Soften the logic in shaka.polyfill.MediaCapabilities.canCastDisplayType_ to treat the !(window.cast) case as a warning instead of an error and fallback to shaka.media.Capabilities.isTypeSupported

@github-actions github-actions bot added this to the v4.4 milestone Feb 17, 2023
@joeyparrish
Copy link
Member

Both? At least 2.

@avelad avelad added platform: TV/STB Issues affecting smart TV or set-top box platforms priority: P1 Big impact or workaround impractical; resolve before feature release labels Feb 20, 2023
JulianDomingo pushed a commit that referenced this issue Feb 28, 2023
joeyparrish pushed a commit that referenced this issue Mar 1, 2023
joeyparrish pushed a commit that referenced this issue Mar 1, 2023
joeyparrish pushed a commit that referenced this issue Mar 1, 2023
joeyparrish pushed a commit that referenced this issue Mar 2, 2023
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Apr 29, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform: TV/STB Issues affecting smart TV or set-top box platforms priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants