Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoCorrectDrift is incorrectly calculated for certain live streams #4944

Closed
littlespex opened this issue Jan 30, 2023 · 0 comments · Fixed by #4945
Closed

autoCorrectDrift is incorrectly calculated for certain live streams #4944

littlespex opened this issue Jan 30, 2023 · 0 comments · Fixed by #4945
Labels
component: DASH The issue involves the MPEG DASH manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@littlespex
Copy link
Contributor

littlespex commented Jan 30, 2023

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
3.4.x

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from main?
Yes

Are you using the demo app or your own custom app?
Both

If custom app, can you reproduce the issue using our demo app?
Yes

What browser and OS are you using?
Chrome, Safari, Edge on macOS Monterey, Tizen, WebOS and others.

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
Not device specific

What are the manifest and license server URIs?

Available upon request

What configuration are you using? What is the output of player.getConfiguration()?

Default

What did you do?

When playing a simulated live stream*, the auto correct drift functionality uses segments ahead of the live edge in its calculations. This is because the current content period is published and available, but the live edge is somewhere in the middle of the period. Using the period's segment template the auto correct calculation uses segments that are "in the future" which results in a negative presentationStartTime. This then incorrectly moves the calculated live edge to the end of the period. The issue does not occur when manifest.dash.autoCorrectDrift is set to false.

*A live stream created by stitching together VOD assets and ad periods.

What did you expect to happen?
The live edge should be the same regardless of the manifest.dash.autoCorrectDrift's value.

What actually happened?

The live edge is calculated "in the future", resulting in stalled playback.

@littlespex littlespex added the type: bug Something isn't working correctly label Jan 30, 2023
@avelad avelad added priority: P1 Big impact or workaround impractical; resolve before feature release component: DASH The issue involves the MPEG DASH manifest format labels Jan 30, 2023
@avelad avelad added this to the v4.4 milestone Jan 30, 2023
littlespex added a commit that referenced this issue Mar 28, 2023
joeyparrish pushed a commit that referenced this issue Apr 26, 2023
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label May 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: DASH The issue involves the MPEG DASH manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
2 participants