Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DASH playback not supported in DAI demos of shakaplayer #4887

Closed
markminnoye opened this issue Jan 12, 2023 · 0 comments · Fixed by #4977
Closed

DASH playback not supported in DAI demos of shakaplayer #4887

markminnoye opened this issue Jan 12, 2023 · 0 comments · Fixed by #4977
Assignees
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs component: demo page The issue is in the demo page; does not affect production applications priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@markminnoye
Copy link

Have you read the FAQ and checked for duplicate open issues?
YES

What link can we use to reproduce this?
https://shaka-player-demo.appspot.com/demo/#audiolang=nl-NL;textlang=nl-NL;uilang=nl-NL;asset=;panel=CUSTOM%20CONTENT;build=uncompiled
using following config :
ADS:content source ID: 2625467
ADS:Video ID: mark_v3

What version of Shaka Player are you using?
v4.3.2 (uncompiled)

What browser and OS are you using?
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/108.0.0.0 Safari/537.36

What did you do?
using a custom shaka demo to test dash vod with SSAI using google DAI.

What did you expect to happen?
Playback of vod with pre-rolls and mid-rolls

What actually happened?
failed to playback

reason:
The dai sdk is making a (POST HTTP) request to DAI service to get information about the asset, to get -a.o.- playbackURL. In the demo app it is using the following URL: POST https://pubads.g.doubleclick.net/ondemand/hls/content/2625467/vid/mark_v3/streams
which returns a 404.
while for dah it should use : https://pubads.g.doubleclick.net/ondemand/dash/content/2625467/vid/mark_v3/streams
which will return a 201 with the following body : {"stream_id":"b1a414d3-ae11-45b6-be7b-a3cdcc8e2675","duration":2890.296,"stream_type":"on_demand","stream_manifest":"https://pubads.g.doubleclick.net/ondemand/dash/content/2625467/vid/mark_v3/GRQ/streams/b1a414d3-ae11-45b6-be7b-a3cdcc8e2675/manifest.mpd","manifest_format":"dash","time_events_url":"https://pubads.g.doubleclick.net/ondemand/dash/content/2625467/vid/mark_v3/GRQ/streams/b1a414d3-ae11-45b6-be7b-a3cdcc8e2675/time-events.json"}

Is there a way to config the demo player to request the dash stream iso the hls stream ?

@avelad avelad added type: bug Something isn't working correctly component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs component: DASH The issue involves the MPEG DASH manifest format labels Jan 12, 2023
@github-actions github-actions bot added this to the v4.4 milestone Jan 12, 2023
@avelad avelad added component: demo page The issue is in the demo page; does not affect production applications and removed component: DASH The issue involves the MPEG DASH manifest format labels Jan 31, 2023
@avelad avelad self-assigned this Feb 8, 2023
@avelad avelad added the priority: P2 Smaller impact or easy workaround label Feb 8, 2023
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Apr 10, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs component: demo page The issue is in the demo page; does not affect production applications priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants