fix(HLS): Fix discontinuity tracking #4881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discontinuity tracking was broken and test coverage was insufficient to catch this. This fixes the parsing and counting of discontinuities, and replaces two outdated and useless tests with a new one that covers the counting properly. One of the old tests was checking that a timestamp offset was set for each discontinuity, but this had become irrelevant since the test was written. Discontinuities do not have anything to do with timestamp offsets in current versions of Shaka Player. The other old test was checking that after a discontinuity, we didn't fetch a segment to parse out the timestamp, but we stopped doing that entirely in v4. The new test checks that the initial discontinuity sequence number is honored, and that after a discontinuity, the number goes up. It also checks that the correct number is extracted after an update. This test fails without the fix, and passes with it.
joeyparrish
added
component: HLS
joeyparrish
requested review from
littlespex,
avelad,
JulianDomingo and
theodab
theodab
approved these changes
Jan 10, 2023
avelad
approved these changes
Jan 10, 2023
|
Incremental code coverage: 100.00% |
joeyparrish
added a commit
that referenced
this pull request
Jan 13, 2023
Discontinuity tracking was broken and test coverage was insufficient to catch this. This fixes the parsing and counting of discontinuities, and replaces two outdated and useless tests with a new one that covers the counting properly. One of the old tests was checking that a timestamp offset was set for each discontinuity, but this had become irrelevant since the test was written. Discontinuities do not have anything to do with timestamp offsets in current versions of Shaka Player. The other old test was checking that after a discontinuity, we didn't fetch a segment to parse out the timestamp, but we stopped doing that entirely in v4. The new test checks that the initial discontinuity sequence number is honored, and that after a discontinuity, the number goes up. It also checks that the correct number is extracted after an update. This test fails without the fix, and passes with it. This bug affected v4.2.6 and v4.3.2 only. Issue #4589
joeyparrish
added a commit
that referenced
this pull request
Jan 13, 2023
Discontinuity tracking was broken and test coverage was insufficient to catch this. This fixes the parsing and counting of discontinuities, and replaces two outdated and useless tests with a new one that covers the counting properly. One of the old tests was checking that a timestamp offset was set for each discontinuity, but this had become irrelevant since the test was written. Discontinuities do not have anything to do with timestamp offsets in current versions of Shaka Player. The other old test was checking that after a discontinuity, we didn't fetch a segment to parse out the timestamp, but we stopped doing that entirely in v4. The new test checks that the initial discontinuity sequence number is honored, and that after a discontinuity, the number goes up. It also checks that the correct number is extracted after an update. This test fails without the fix, and passes with it. This bug affected v4.2.6 and v4.3.2 only. Issue #4589
Robloche
pushed a commit
to Robloche/shaka-player
that referenced
this pull request
Feb 8, 2023
Discontinuity tracking was broken and test coverage was insufficient to catch this. This fixes the parsing and counting of discontinuities, and replaces two outdated and useless tests with a new one that covers the counting properly. One of the old tests was checking that a timestamp offset was set for each discontinuity, but this had become irrelevant since the test was written. Discontinuities do not have anything to do with timestamp offsets in current versions of Shaka Player. The other old test was checking that after a discontinuity, we didn't fetch a segment to parse out the timestamp, but we stopped doing that entirely in v4. The new test checks that the initial discontinuity sequence number is honored, and that after a discontinuity, the number goes up. It also checks that the correct number is extracted after an update. This test fails without the fix, and passes with it. This bug affected v4.2.6 and v4.3.2 only. Issue shaka-project#4589
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discontinuity tracking was broken and test coverage was insufficient to catch this. This fixes the parsing and counting of discontinuities, and replaces two outdated and useless tests with a new one that covers the counting properly.
One of the old tests was checking that a timestamp offset was set for each discontinuity, but this had become irrelevant since the test was written. Discontinuities do not have anything to do with timestamp offsets in current versions of Shaka Player.
The other old test was checking that after a discontinuity, we didn't fetch a segment to parse out the timestamp, but we stopped doing that entirely in v4.
The new test checks that the initial discontinuity sequence number is honored, and that after a discontinuity, the number goes up. It also checks that the correct number is extracted after an update. This test fails without the fix, and passes with it.
This bug affected v4.2.6 and v4.3.2 only.
Issue #4589