Control buttons should have type "button"

[Andekas]

Have you read the FAQ and checked for duplicate open issues?

Yes

What version of Shaka Player are you using?

4.3.0.

Can you reproduce the issue with our latest release version?

Yes

Can you reproduce the issue with the latest code from main?

Yes

Are you using the demo app or your own custom app?

Both

If custom app, can you reproduce the issue using our demo app?

Yes

What browser and OS are you using?

Chrome, Windows

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?

What configuration are you using? What is the output of player.getConfiguration()?

What did you do?

Create video player inside a

. Click on a button on player controls.

What did you expect to happen?
Only what the button is supposed to do.

What actually happened?

Button (let's say start / pause) does what it does. But as this is a element without a type parameter, then if player is inside a form, form gets submitted also. For most browsers, the default type value is "submit". Player controls should have button type "button".

[WINOFFRG]

You are right, This can cause issues with forms. But I don't think this is a valid case even, because you can always redesign the things. But in case you are really looking to change the type on button, You can simply run a selector query on all the buttons inside shaka parents container or always modify the code from UI Library.

[Andekas]

Sure, this is not a major issue and can be easily fixed / bypassed. But I still think that defining default button's type would be a good practice - and as far as I can see, there is no reason, why it has to be "submit". The less changes / custom solutions you have to do, the better.