Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to WebVTT voice tags #4844

Closed
avelad opened this issue Dec 16, 2022 · 0 comments · Fixed by #4845
Closed

Add support to WebVTT voice tags #4844

avelad opened this issue Dec 16, 2022 · 0 comments · Fixed by #4845
Assignees
@avelad
Labels
component: WebVTT The issue involves WebVTT subtitles specifically priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone
v4.4

Comments

@avelad
Copy link
Member

avelad commented Dec 16, 2022

See https://www.w3.org/TR/webvtt1/#styling
@avelad avelad added the type: enhancement New feature or request label Dec 16, 2022
@avelad avelad self-assigned this Dec 16, 2022
@avelad avelad added this to the v4.4 milestone Dec 16, 2022
@avelad avelad added priority: P2 Smaller impact or easy workaround component: WebVTT The issue involves WebVTT subtitles specifically labels Dec 16, 2022
@avelad avelad mentioned this issue Dec 16, 2022
Merged
avelad added a commit that referenced this issue Jan 19, 2023
@avelad
feat(WebVTT): Add support to voice tag styles (#4845)
a5f8b43 
closes #4844
fixes #4843
fixes #4479
joeyparrish pushed a commit that referenced this issue Jan 30, 2023
@avelad @joeyparrish
fix(WebVTT): Add support to voice tag styles (#4845)
4fb19fb 
closes #4844
fixes #4843
fixes #4479
joeyparrish pushed a commit that referenced this issue Jan 30, 2023
@avelad @joeyparrish
fix(WebVTT): Add support to voice tag styles (#4845)
e8465a2 
closes #4844
fixes #4843
fixes #4479
joeyparrish pushed a commit that referenced this issue Jan 30, 2023
@avelad @joeyparrish
fix(WebVTT): Add support to voice tag styles (#4845)
acbfca1 
closes #4844
fixes #4843
fixes #4479
joeyparrish pushed a commit that referenced this issue Jan 30, 2023
@avelad @joeyparrish
fix(WebVTT): Add support to voice tag styles (#4845)
88602be 
closes #4844
fixes #4843
fixes #4479
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Mar 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@avelad avelad

Labels
component: WebVTT The issue involves WebVTT subtitles specifically priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.4
Development

Successfully merging a pull request may close this issue.

fix(WebVTT): Add support to voice tag styles avelad/shaka-player
1 participant
@avelad