feat: Cache mediaCapabilities.decodingInfo results #4789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
previously approved these changes
Dec 5, 2022
|
Incremental code coverage: 100.00% |
avelad
approved these changes
Dec 5, 2022
joeyparrish
reviewed
Dec 6, 2022
| */ | ||
| static async getDecodingInfosForVariant_(variant, decodingConfig) { | ||
| try { | ||
| const cacheKey = JSON.stringify(decodingConfig); |
There was a problem hiding this comment.
This is a problematic key. If the fields are serialized in a different order, this will fail to match.
It's better than no caching, but this needs work. Please file an issue to follow-up on this.
There was a problem hiding this comment.
(There's an entire ToTT episode on this subject, BTW, in context of comparing objects in tests using JSON.stringify. But it still applies here.)
joeyparrish
reviewed
Dec 6, 2022
| * (stringified) decodingConfig. | ||
| * | ||
| * @type {Object.<(!string), (!MediaCapabilitiesDecodingInfo)>} | ||
| * @export |
There was a problem hiding this comment.
Why is this exported? I don't think we want this exposed to the application and subject to backward compatibility guarantees.
If you just need it for unit testing, use @suppress in a test helper instead.
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #4775