-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support Parallel Segment Fetching #4784
Conversation
Incremental code coverage: 98.17% |
Thanks for your patience, I'll try to review it throughout this week. |
I skimmed this PR, and it looks interesting and well-constructed. You've designed something that appears to address most of my concerns, it defaults to 0 (good for low-memory devices), and the prefetcher cleans up after itself so it doesn't hold onto an unbounded number of segments. This could also be useful in a future implementation of #880 (preload API). I haven't read it in detail, and I have some deadlines to get AV sync fixes done this week before we go on holidays at Google. But I will come back to this in January for a detailed review, and I expect this is something that will ultimately ship in Shaka Player. Thanks for your contribution! |
Thanks @joeyparrish ! Thanks again for helping on the code reviews ! |
We can make a feature release at any time. We don't have a fixed release cycle. |
@tyrelltle can you rebase and resolve the conflicts? Thanks! |
b1690c8
to
81a9c67
Compare
@avelad yes I just rebased now |
@theodab thanks for the comments ! |
addressed some of the comments, will finish other ones by tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work, by the way.
Thanks for the comments I updated all of them. Let me know if any other suggestions :) |
closes #4658.
This solution is inspired by abandoned PR #2809, which implements segment prefetching ahead of current play head.