Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLS subtitles lose role information #4759

Closed
fredrik-telia opened this issue Nov 25, 2022 · 1 comment · Fixed by #4760
Closed

HLS subtitles lose role information #4759

fredrik-telia opened this issue Nov 25, 2022 · 1 comment · Fixed by #4760
Assignees
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@fredrik-telia
Copy link
Contributor

fredrik-telia commented Nov 25, 2022

Have you read the FAQ and checked for duplicate open issues?
yes

What version of Shaka Player are you using?
latest

Can you reproduce the issue with our latest release version?
yes

Can you reproduce the issue with the latest code from main?
yes

Are you using the demo app or your own custom app?
own custom app

If custom app, can you reproduce the issue using our demo app?
n/a

What browser and OS are you using?
Chrome, macOS

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?

n/a

What configuration are you using? What is the output of player.getConfiguration()?

n/a

What did you do?

Play HLS content that has both captions and subtitles, the captions having the EXT-MEDIA-TAG as follows:

#EXT-X-MEDIA:TYPE=SUBTITLES,GROUP-ID="sub1",LANGUAGE="sv",NAME="Swedish [SDH]",AUTOSELECT=YES,CHARACTERISTICS="public.accessibility.describes-music-and-sound",URI="sc-gaFESg/s2_index.m3u8"

What did you expect to happen?
The subtitle track parsed as having roles: ["public.accessibility.describes-music-and-sound"]

What actually happened?
There is no information in the shaka track object regarding what roles (or kind) this track has, so there is no way of distinguishing it as captions.

I have a fix locally that solves the problem, and could make a pull request. It would be good to have someone with more knowledge of hls_parser.js to take a look at it.

@fredrik-telia fredrik-telia added the type: bug Something isn't working correctly label Nov 25, 2022
@github-actions github-actions bot added this to the v4.4 milestone Nov 25, 2022
@avelad avelad added the component: HLS The issue involves Apple's HLS manifest format label Nov 29, 2022
@joeyparrish
Copy link
Member

Based on the PR, I think regression was introduced in v4.3.0 with lazy-loading changes. This bug does not appear to affect any other release.

joeyparrish added a commit that referenced this issue Dec 7, 2022
Issue wasn't caught by the existing tests.

Closes #4759

Co-authored-by: Joey Parrish <[email protected]>
@avelad avelad added the priority: P1 Big impact or workaround impractical; resolve before feature release label Dec 7, 2022
joeyparrish added a commit that referenced this issue Dec 8, 2022
Issue wasn't caught by the existing tests.

Closes #4759

Co-authored-by: Joey Parrish <[email protected]>
joeyparrish added a commit that referenced this issue Dec 8, 2022
Issue wasn't caught by the existing tests.

Closes #4759

Co-authored-by: Joey Parrish <[email protected]>
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Feb 5, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants