-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Focus is lost on first element when back to the settings menu #4652
Labels
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
Milestone
Comments
joeyparrish
pushed a commit
that referenced
this issue
Nov 4, 2022
Going to the configuration menu using the keyboard and entering some menu, when going back the focus is lost because the first element of the HTML tree is hidden. This makes it difficult to use the player using accessibility shortcuts. Closes #4652 Co-authored-by: Gonzalo Rodriguez <[email protected]>
joeyparrish
pushed a commit
that referenced
this issue
Nov 8, 2022
Going to the configuration menu using the keyboard and entering some menu, when going back the focus is lost because the first element of the HTML tree is hidden. This makes it difficult to use the player using accessibility shortcuts. Closes #4652 Co-authored-by: Gonzalo Rodriguez <[email protected]>
joeyparrish
pushed a commit
that referenced
this issue
Nov 8, 2022
Going to the configuration menu using the keyboard and entering some menu, when going back the focus is lost because the first element of the HTML tree is hidden. This makes it difficult to use the player using accessibility shortcuts. Closes #4652 Co-authored-by: Gonzalo Rodriguez <[email protected]>
joeyparrish
pushed a commit
that referenced
this issue
Nov 8, 2022
Going to the configuration menu using the keyboard and entering some menu, when going back the focus is lost because the first element of the HTML tree is hidden. This makes it difficult to use the player using accessibility shortcuts. Closes #4652 Co-authored-by: Gonzalo Rodriguez <[email protected]>
github-actions
bot
added
the
status: archived
Archived and locked; will not be updated
label
Jan 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
4.2.2
Can you reproduce the issue with our latest release version?
Yes
Can you reproduce the issue with the latest code from
main
?Yes
Are you using the demo app or your own custom app?
Demo app
What browser and OS are you using?
Google Chrome
What are the manifest and license server URIs?
Demo: https://shaka-player-demo.appspot.com/demo/#audiolang=en-US;textlang=en-US;uilang=en-US;asset=https://storage.googleapis.com/shaka-demo-assets/bbb-dark-truths-hls/hls.m3u8;panel=HOME;build=uncompiled
What configuration are you using? What is the output of
player.getConfiguration()
?Default
What did you do?
Going to the configuration menu using the keyboard and entering some menu, when going back the focus is lost because the first element of the HTML tree is hidden.
What did you expect to happen?
When goes back to the primary setting menu the focus should stay on the first visible element.
What actually happened?
The focus goes away causing the menu to remain open and the user loses the focus pointer.
The text was updated successfully, but these errors were encountered: