fix(playhead): safeguard getStallsDetected as stallDetector can be null #4581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Incremental code coverage: 100.00% |
avelad
added
type: bug
avelad
approved these changes
Oct 15, 2022
theodab
approved these changes
Oct 18, 2022
joeyparrish
pushed a commit
that referenced
this pull request
Oct 18, 2022
…ll (#4581) `player.getStats()` currently fails when `stallEnabled` is set to false in Player configuration. In this PR I've added a safeguard to make sure `getStallsDetected` returns 0 when `stallDetector` is null.
joeyparrish
pushed a commit
that referenced
this pull request
Oct 18, 2022
…ll (#4581) `player.getStats()` currently fails when `stallEnabled` is set to false in Player configuration. In this PR I've added a safeguard to make sure `getStallsDetected` returns 0 when `stallDetector` is null.
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
player.getStats()currently fails whenstallEnabledis set to false in Player configuration. In this PR I've added a safeguard to make suregetStallsDetectedreturns 0 whenstallDetectoris null.