fix(playhead): Safeguard getStallsDetected as stallDetector can be nu…

…ll (#4581) `player.getStats()` currently fails when `stallEnabled` is set to false in Player configuration. In this PR I've added a safeguard to make sure `getStallsDetected` returns 0 when `stallDetector` is null.
shaka-project · Oct 18, 2022 · 5d12efd · 5d12efd
1 parent ca60381
commit 5d12efd
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/AUTHORS b/AUTHORS
@@ -83,3 +83,4 @@ Vincent Valot <[email protected]>
 Wayne Morgan <[email protected]>
 Raymond Cheng <[email protected]>
 Blue Billywig <*@bluebillywig.com>
+Koen Romers <[email protected]>
diff --git a/CONTRIBUTORS b/CONTRIBUTORS
@@ -123,3 +123,4 @@ Wayne Morgan <[email protected]>
 Yohann Connell <[email protected]>
 Raymond Cheng <[email protected]>
 Janroel Koppen <[email protected]>
+Koen Romers <[email protected]>
diff --git a/lib/media/playhead.js b/lib/media/playhead.js
@@ -294,7 +294,7 @@ shaka.media.MediaSourcePlayhead = class {
 
   /** @override */
   getStallsDetected() {
-    return this.stallDetector_.getStallsDetected();
+    return this.stallDetector_ ? this.stallDetector_.getStallsDetected() : 0;
   }
 
   /** @override */