Ads in the player

[hiren3897]

Have you read the Tutorials?
YES

Have you read the FAQ and checked for duplicate open issues?
YES

What version of Shaka Player are you using?
3.2

Please ask your question
Can you please give me a quick brief on inserting the ads in the shaka-player?

I have already read this documentation: https://shaka-player-demo.appspot.com/docs/api/tutorial-ad_monetization.html

It says after v3.1+ shaka player will support other ads providers, do we have it as we can see we have 4.2 released?

If yes, how we should integrate that?

[joeyparrish]

It says after v3.1+ shaka player will support other ads providers

Unfortunately, we never implemented that. I would be happy to discuss the design with you if you want to be part of the solution to extend it. Currently, this is not on our roadmap. Unless you are interested in the work, I think we should remove that mention from the docs.

[hiren3897]

Okay, thanks for the response
I will talk with my team and let you know :)

[hiren3897]

"TypeError: Cannot read properties of null (reading 'isLinear')

When I tried to follow your tutorial, I am getting this error above.

My questions:

We can request ads anytime during the presentation?
After the ad gets end does the player have the capability to switch back to the original video automatically?
Do we have a skip button UI or do I need to work on that to create a button to skip the ads?

[theodab]

It's hard to say without the full stack trace, but that TypeError looks like we are getting a CONTENT_PAUSE_REQUESTED or STARTED event from the IMA SDK, but the event has no associated ad.
I don't know why that would happen, admittedly. I'm not an IMA SDK expert or anything.
We should probably have a more useful error for if that happens. I'll put in an assert, maybe.

As to your questions,

1. I believe you can request ads at any time during the presentation, yes.
2. The player should automatically return to the original video after an ad.
3. The UI has a skip ad button. It shows up based on the getAdSkippableState method of the IMA AdsManager.

[hiren3897]

Thanks, @theodab for the response

Can you send me any adsTagURl that is working because I am using the ads URL from this google sample source:
https://developers.google.com/interactive-media-ads/docs/sdks/html5/client-side/tags

None of them are working for me!!

It also gives me an error when I run it on localhost. Does it require only https?

[theodab]

The ad tag URIs we are using for demo content are here:

shaka-player/demo/common/assets.js

Lines 56 to 76 in 8475214

	/** @enum {string} */
	shakaAssets.AdTag = {
	SINGLE_LINEAR_AD: 'https://pubads.g.doubleclick.net/gampad/ads?sz=640x480' +
	'&iu=/124319096/external/' +
	'single_ad_samples&ciu_szs=300x250&impl=s&gdfp_req=1&env=vp&output=vast&' +
	'unviewed_position_start=1&cust_params=deployment%3Ddevsite%26sample_ct%' +
	'3Dlinear&correlator=',
	SINGLE_NON_LINEAR_AD: 'https://pubads.g.doubleclick.net/gampad/ads?' +
	'sz=480x70&iu=/124319096/external/single_ad_samples&ciu_szs=300x250 ' +
	'&impl=s&gdfp_req=1&env=vp&output=vast&unviewed_position_start=1' +
	'&cust_params=deployment%3Ddevsite%26sample_ct%3Dnonlinear&correlator=',
	SINGLE_SKIPPABLE_AD: 'https://pubads.g.doubleclick.net/gampad/ads?sz=640x480&iu=/' +
	'124319096/external/single_ad_samples&ciu_szs=300x250&impl=s&' +
	'gdfp_req=1&env=vp&output=vast&unviewed_position_start=1&cust_params=' +
	'deployment%3Ddevsite%26sample_ct%3Dskippablelinear&correlator=',
	AD_POD_PREROLL_MIDROLL_POSTROLL: 'https://pubads.g.doubleclick.net/gampad/ads?' +
	'sz=640x480&iu=/124319096/external/ad_rule_samples&' +
	'ciu_szs=300x250&ad_rule=1&impl=s&gdfp_req=1&env=vp&output=' +
	'vmap&unviewed_position_start=1&cust_params=deployment%3Ddevsite' +
	'%26sample_ar%3Dpremidpostpod&cmsid=496&vid=short_onecue&correlator=',
	};

I'm... not sure where they come from, to be honest. I didn't make the ad stuff. I assume they are some kind of sample ads.

It should work when hosted on localhost. I test things over localhost, most of the time.

[hiren3897]

When running on localhost I have this error :'/

[hiren3897]

Did the fix made by you resolve the problem of "TypeError: Cannot read properties of null (reading 'isLinear') ?

[joeyparrish]

@hiren3897, please try again with the latest source from the main branch and let us know your results.

[hiren3897]

Hello @joeyparrish,

The error seems to be resolved but I am not able to see the ad on the player.

    requestAds() {
        this.adManager.initClientSide(this.clientSideAdContainer, this.video_);

        const adsRequest = new google.ima.AdsRequest();

        // Your ad tag url should go here. We are using a sample ad tag from the
        // IMA HTML5 SDK implementation guide for this tutorial.
        adsRequest.adTagUrl = 'https://pubads.g.doubleclick.net/gampad/ads?sz=640x480' +
            '&iu=/124319096/external/' +
            'single_ad_samples&ciu_szs=300x250&impl=s&gdfp_req=1&env=vp&output=vast&' +
            'unviewed_position_start=1&cust_params=deployment%3Ddevsite%26sample_ct%' +
            '3Dlinear&correlator=';

        this.adManager.requestClientSideAds(adsRequest);
    }

If I debug my DOM elements, I do have contents in shaka-client-side-ad-container

But the ad doesn't play!!
Am I doing something wrong?

[hiren3897]

It was an issue of cors but the bug has been resolved!!

I am not able to request multiple ads in the player.

For example, I want to display 3 ads in the player at any time during the video is played.

Can you tell me how can I do that with the cue points on the UI?

I tried to request the ads but the second request doesn't work.