Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolution disappear if network intermittent #4408

Closed
kocoten1992 opened this issue Aug 15, 2022 · 2 comments · Fixed by #4426 or #4424
Closed

Resolution disappear if network intermittent #4408

kocoten1992 opened this issue Aug 15, 2022 · 2 comments · Fixed by #4426 or #4424
Assignees
@joeyparrish
Labels
priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v4.3

Comments

@kocoten1992
Copy link
Contributor

kocoten1992 commented Aug 15, 2022 •
edited
Loading

Have you read the FAQ and checked for duplicate open issues?
Yes.

What version of Shaka Player are you using?
v4.1.2

Can you reproduce the issue with our latest release version?
Yes.

Can you reproduce the issue with the latest code from main?
Probably.

Are you using the demo app or your own custom app?
Both.

If custom app, can you reproduce the issue using our demo app?
Yes.

What browser and OS are you using?
Google Chrome.

What did you do?
Go to, https://shaka-player-demo.appspot.com/demo/#audiolang=en-US;textlang=en-US;uilang=en-US;asset=https://storage.googleapis.com/shaka-demo-assets/sintel-widevine/dash.mpd;adTagUri=https://pubads.g.doubleclick.net/gampad/ads?sz=640x480&iu=/124319096/external/ad_rule_samples&ciu_szs=300x250&ad_rule=1&impl=s&gdfp_req=1&env=vp&output=vmap&unviewed_position_start=1&cust_params=deployment%3Ddevsite%26sample_ar%3Dpremidpostpod&cmsid=496&vid=short_onecue&correlator=;panel=HOME;build=uncompiled

Select a resolution (818 maybe), then Press F12 open chrome dev tool, go to network tab and select Offline, wait about 20s, now check resolution on player, it all gone (see image below).

What did you expect to happen?
Resolution still there.

What actually happened?
Resolution disappear.

image
@kocoten1992 kocoten1992 added the type: bug Something isn't working correctly label Aug 15, 2022
@github-actions github-actions bot added this to the v4.2 milestone Aug 15, 2022
@avelad avelad modified the milestones: v4.2, v4.3 Aug 17, 2022
@joeyparrish joeyparrish added the priority: P1 Big impact or workaround impractical; resolve before feature release label Aug 18, 2022
@joeyparrish
Copy link
Member

joeyparrish commented Aug 18, 2022 •
edited
Loading

Confirmed. I think this has to do with a feature that was added to restrict tracks when requests start to fail. (PR #4189)

@joeyparrish
Copy link
Member

This issue affects all v4.1 and v4.2 releases.

@joeyparrish joeyparrish self-assigned this Aug 18, 2022
joeyparrish added a commit to joeyparrish/shaka-player that referenced this issue Aug 18, 2022
@joeyparrish
fix: Fix vanishing tracks while offline
4a43ea4 
Introduced in shaka-project#4189, as a side-effect of restricting tracks when a
network failure occurs.  We should not trigger such restrictions when
the browser is known to be offline.

Closes shaka-project#4408
@joeyparrish joeyparrish mentioned this issue Aug 18, 2022
Merged
joeyparrish added a commit that referenced this issue Aug 18, 2022
@joeyparrish
fix: Fix vanishing tracks while offline (#4426)
c935cc1 
Introduced in #4189, as a side-effect of restricting tracks when a
network failure occurs.  We should not trigger such restrictions when
the browser is known to be offline.

Closes #4408
@github-actions github-actions bot mentioned this issue Aug 18, 2022
Merged
avelad pushed a commit that referenced this issue Aug 31, 2022
@joeyparrish
fix: Fix vanishing tracks while offline (#4426)
186d298 
Introduced in #4189, as a side-effect of restricting tracks when a
network failure occurs.  We should not trigger such restrictions when
the browser is known to be offline.

Closes #4408
@github-actions github-actions bot mentioned this issue Aug 31, 2022
Merged
avelad pushed a commit that referenced this issue Aug 31, 2022
@joeyparrish
fix: Fix vanishing tracks while offline (#4426)
d668790 
Introduced in #4189, as a side-effect of restricting tracks when a
network failure occurs.  We should not trigger such restrictions when
the browser is known to be offline.

Closes #4408
@github-actions github-actions bot mentioned this issue Aug 31, 2022
Merged
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Oct 17, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joeyparrish joeyparrish

Labels
priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.3
3 participants
@joeyparrish @kocoten1992 @avelad