Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spatial audio flag not being set on variant tracks #4290

Closed
littlespex opened this issue Jun 13, 2022 · 1 comment
Closed

Spatial audio flag not being set on variant tracks #4290

littlespex opened this issue Jun 13, 2022 · 1 comment
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v4.2

Comments

@littlespex
Copy link
Contributor

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
3.3.6 - 4.1.0

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from main?
Yes

Are you using the demo app or your own custom app?
Both

If custom app, can you reproduce the issue using our demo app?
Yes

What browser and OS are you using?
All browsers

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?

Send separately

What configuration are you using? What is the output of player.getConfiguration()?

Default

What did you do?

  1. Load a stream with a Dolby Atmos representation
  2. Call getVariantTracks()

What did you expect to happen?
Some of the tracks should be listed with spatialAudio as true

What actually happened?

All of the tracks are listed with spatialAudio as false
@littlespex littlespex added the type: bug Something isn't working correctly label Jun 13, 2022
@littlespex littlespex mentioned this issue Jun 13, 2022
Merged
@github-actions github-actions bot added this to the v4.2 milestone Jun 13, 2022
joeyparrish pushed a commit that referenced this issue Jun 13, 2022
@littlespex @dsparacio
fix: Populate track's spatialAudio property (#4291)
713f461 
Fixes issue #4290 where `spatialAudio` flag is not being set on variant tracks.

Co-authored-by: Dan Sparacio <[email protected]>
@joeyparrish
Copy link
Member

Fixed in #4291

avelad pushed a commit that referenced this issue Jun 14, 2022
@littlespex @dsparacio
fix: Populate track's spatialAudio property (#4291)
636f232 
Fixes issue #4290 where `spatialAudio` flag is not being set on variant tracks.

Co-authored-by: Dan Sparacio <[email protected]>
avelad pushed a commit that referenced this issue Jun 14, 2022
@littlespex @dsparacio
fix: Populate track's spatialAudio property (#4291)
46343f0 
Fixes issue #4290 where `spatialAudio` flag is not being set on variant tracks.

Co-authored-by: Dan Sparacio <[email protected]>
avelad pushed a commit that referenced this issue Jun 14, 2022
@littlespex @dsparacio
fix: Populate track's spatialAudio property (#4291)
43fb21c 
Fixes issue #4290 where `spatialAudio` flag is not being set on variant tracks.

Co-authored-by: Dan Sparacio <[email protected]>
joeyparrish pushed a commit that referenced this issue Jun 14, 2022
@littlespex @dsparacio @joeyparrish
fix: Populate track's spatialAudio property (#4291)
ab1b442 
Fixes issue #4290 where `spatialAudio` flag is not being set on variant tracks.

Co-authored-by: Dan Sparacio <[email protected]>
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Aug 12, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.2
Development

No branches or pull requests
2 participants
@littlespex @joeyparrish