-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safari failing Load Graph tests #4087
Labels
priority: P2
Smaller impact or easy workaround
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
Milestone
Comments
joeyparrish
added
type: bug
Something isn't working correctly
priority: P2
Smaller impact or easy workaround
labels
Mar 30, 2022
joeyparrish
added a commit
to joeyparrish/shaka-player
that referenced
this issue
Mar 30, 2022
Some events and timers were used to process track changes with src= playback on Safari, but they did not properly clean up when the player was unloaded or destroyed. In the case that this happened quickly after starting playback, exceptions would be thrown or tracks could manipulated after new content began. This fixes the cleanup of these timers and events to be aware of Player unloads or destruction. Closes shaka-project#4087
joeyparrish
added a commit
that referenced
this issue
Mar 31, 2022
Some events and timers were used to process track changes with src= playback on Safari, but they did not properly clean up when the player was unloaded or destroyed. In the case that this happened quickly after starting playback, exceptions would be thrown or tracks could manipulated after new content began. This fixes the cleanup of these timers and events to be aware of Player unloads or destruction. Closes #4087
joeyparrish
added a commit
that referenced
this issue
Apr 21, 2022
Some events and timers were used to process track changes with src= playback on Safari, but they did not properly clean up when the player was unloaded or destroyed. In the case that this happened quickly after starting playback, exceptions would be thrown or tracks could manipulated after new content began. This fixes the cleanup of these timers and events to be aware of Player unloads or destruction. Closes #4087
joeyparrish
added a commit
that referenced
this issue
Apr 21, 2022
Some events and timers were used to process track changes with src= playback on Safari, but they did not properly clean up when the player was unloaded or destroyed. In the case that this happened quickly after starting playback, exceptions would be thrown or tracks could manipulated after new content began. This fixes the cleanup of these timers and events to be aware of Player unloads or destruction. Closes #4087
joeyparrish
added a commit
that referenced
this issue
Apr 21, 2022
Some events and timers were used to process track changes with src= playback on Safari, but they did not properly clean up when the player was unloaded or destroyed. In the case that this happened quickly after starting playback, exceptions would be thrown or tracks could manipulated after new content began. This fixes the cleanup of these timers and events to be aware of Player unloads or destruction. Closes #4087
github-actions
bot
added
the
status: archived
Archived and locked; will not be updated
label
May 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
priority: P2
Smaller impact or easy workaround
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
It appears that this code is to blame in lib/player.js:
When the timer fires, the player has already been destroyed.
The text was updated successfully, but these errors were encountered: