-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Questions about chapters API #3895
Comments
To add a bit more context here, when shaka downloads a captions VTT file it appears to do so from a JS |
Hi @hochhaus
|
Thanks @avelad. I opened a dedicated issue per your comments so I will close this issue. |
I also am not able to find this documented and the current implementation is not problematic. Should I find HLS / DASH documentation in the future I will open a dedicated issue. |
Have you read the Tutorials?
Yes
Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
v3.3.0
Please ask your question
I'm experimenting with the chapters API referencing the code, tests and comments (#3538 (comment)). Could you clarify my understanding of the following items?
player.addChaptersTrack()
instead of being included in the manifest? This isn't the end of the world but it seems unintuitive to me.addChaptersTrack()
promise resolve before the chapters file has been downloaded and parsed by the browser? This seems to unnecessarily increase the complexity of correctly using chapters.shaka.extern.Chapter
not include the cue identifier (shaka.extern.Cue.id
)? The calling code can pull this information directly out of the cue but it seems to unnecessarily complicate certain use cases.The text was updated successfully, but these errors were encountered: