CEA 608 captions not working with shaka 3.1.3 and 3.2.1 #3782
Assignees
Labels
component: captions/subtitles
The issue involves captions or subtitles
priority: P1
Big impact or workaround impractical; resolve before feature release
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
Milestone
Comments
caridley
changed the title
|
I'm not seeing this issue with our CEA-608 demo content. Could you provide your stream info? You can send it to [email protected]. |
theodab
added
component: captions/subtitles
|
I have shared info on how to access stream via [email protected] |
|
b6d7138 should fix this. If it doesn't, you can re-open this issue. |
bcupac
pushed a commit
to bcupac/shaka-player
that referenced
this issue
Dec 6, 2021
When we attach closed-caption cues to the text engine, we apply the video timestamp offset to the cues, so that they can align with the start of the stream. However, we previously forgot to apply that offset to any nested cues. This did not matter beforehand, since we previously ignored the start and end times of nested cues. However, recent changes to the UI text displayer changed that. So this fixes nested cues to apply video timestamp offset. Closes shaka-project#3782 Change-Id: I4c9140fcfa9bf94579f8d847e546ee4e2ec5eff4 (cherry picked from commit b6d7138)
joeyparrish
pushed a commit
that referenced
this issue
Jan 5, 2022
When we attach closed-caption cues to the text engine, we apply the video timestamp offset to the cues, so that they can align with the start of the stream. However, we previously forgot to apply that offset to any nested cues. This did not matter beforehand, since we previously ignored the start and end times of nested cues. However, recent changes to the UI text displayer changed that. So this fixes nested cues to apply video timestamp offset. Closes #3782 Change-Id: I4c9140fcfa9bf94579f8d847e546ee4e2ec5eff4
joeyparrish
pushed a commit
that referenced
this issue
Jan 5, 2022
When we attach closed-caption cues to the text engine, we apply the video timestamp offset to the cues, so that they can align with the start of the stream. However, we previously forgot to apply that offset to any nested cues. This did not matter beforehand, since we previously ignored the start and end times of nested cues. However, recent changes to the UI text displayer changed that. So this fixes nested cues to apply video timestamp offset. Closes #3782 Change-Id: I4c9140fcfa9bf94579f8d847e546ee4e2ec5eff4
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
We see this problem with shaka 3.1.3 and 3.2.1
Can you reproduce the issue with our latest release version?
Yes
Can you reproduce the issue with the latest code from
master?Yes
Are you using the demo app or your own custom app?
Custom app
If custom app, can you reproduce the issue using our demo app?
Yes
What browser and OS are you using?
Chrome on MAC
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
What are the manifest and license server URIs?
We will share stream and license URL information if necessary.
But I expect that this can be reproduced using any stream that has 608 captions.
What configuration are you using? What is the output of
player.getConfiguration()?Will provide this if necessary
What did you do?
Play stream with CEA-608 text track selected
What did you expect to happen?
Captions should be presented in the UI
What actually happened?
Caption are not displayed.
I have isolated the problem to this commit in the v3.1.x branch
fix(ttml): Fix ttml erroneously dismissing cues. 7ae5d10 Oct 12, 2021 at 12:31 PM
prior to that commit our 608 captions work, after they do not
The text was updated successfully, but these errors were encountered: