Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chromecast] androidReceiverCompatible not supported #3772

Closed
ProtoScott opened this issue Nov 25, 2021 · 1 comment · Fixed by #4183
Closed

[Chromecast] androidReceiverCompatible not supported #3772

ProtoScott opened this issue Nov 25, 2021 · 1 comment · Fixed by #4183
Labels
platform: Cast Issues affecting Cast devices priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone

Comments

@ProtoScott
Copy link

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
3.2.1

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from master?
Yes

Are you using the demo app or your own custom app?
Both

If custom app, can you reproduce the issue using our demo app?
Yes

What browser and OS are you using?
Chrrome

What did you do?
Tried casting to a Chromecast App Id which has an Android TV app package in it's configuration.

What did you expect to happen?
ShakaPlayer should have tried casting to the Android TV Receiver App.

What actually happened?
ShakaPlayer started casting to the Web Receiver App.
We have proved that this functionality works with ExoPlayer from an Android (Phone) sender app.

Looking at the Shaka source there is no implementation of:
androidReceiverCompatible
Optional, boolean
Indicates if the app is compatible with an Android Receiver.

Reference:
https://developers.google.com/cast/docs/reference/web_sender/chrome.cast.SessionRequest

@ProtoScott ProtoScott added the type: bug Something isn't working correctly label Nov 25, 2021
@ProtoScott
Copy link
Author

I have already written a fix for this and will hopefully raise a PR in the next hour or so.

@shaka-bot shaka-bot added this to the v3.3 milestone Nov 25, 2021
@TheModMaker TheModMaker added priority: P2 Smaller impact or easy workaround type: enhancement New feature or request and removed type: bug Something isn't working correctly labels Jan 21, 2022
@avelad avelad added the platform: Cast Issues affecting Cast devices label May 2, 2022
@avelad avelad modified the milestones: v3.3, v4.1 May 4, 2022
joeyparrish pushed a commit that referenced this issue May 5, 2022
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 4, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform: Cast Issues affecting Cast devices priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
4 participants