Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current time's height wrong on safari #3739

Closed
ScripterYoda opened this issue Nov 3, 2021 · 0 comments · Fixed by #3809
Closed

Current time's height wrong on safari #3739

ScripterYoda opened this issue Nov 3, 2021 · 0 comments · Fixed by #3809
Labels
browser: Safari Issues affecting Safari or WebKit derivatives component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v3.3

Comments

@ScripterYoda
Copy link

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
3.2.1

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from master?
Yes

What browser and OS are you using?
Safari browser v13

What did you do?
Open any video, even in Shaka Player Demo in safari browser.

What did you expect to happen?
To have current time shown properly.

What actually happened?
The height of element containg current time is too small for the text, so the text is cropped.

image

Deleting height:auto from https://github.com/google/shaka-player/blob/71a5fb5f211b6b2ec1af5d621bdebe82c77889ca/ui/less/buttons.less#L81resolves the issue, but I do not know how this change would affect the interface on other browsers.
@ScripterYoda ScripterYoda added the type: bug Something isn't working correctly label Nov 3, 2021
@shaka-bot shaka-bot added this to the v3.3 milestone Nov 3, 2021
@joeyparrish joeyparrish added browser: Safari Issues affecting Safari or WebKit derivatives component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround labels Nov 3, 2021
@avelad avelad mentioned this issue Dec 17, 2021
Merged
theodab pushed a commit that referenced this issue Jan 7, 2022
Fix(UI): Fix time element height on Safari (#3809)
680ab22 
Closes #3739
joeyparrish pushed a commit that referenced this issue Jan 7, 2022
@joeyparrish
Fix(UI): Fix time element height on Safari (#3809)
02020ed 
Closes #3739
joeyparrish pushed a commit that referenced this issue Jan 7, 2022
@joeyparrish
Fix(UI): Fix time element height on Safari (#3809)
2aac304 
Closes #3739
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Mar 8, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
browser: Safari Issues affecting Safari or WebKit derivatives component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v3.3
Development

Successfully merging a pull request may close this issue.

Fix current time's height on safari avelad/shaka-player
3 participants
@joeyparrish @ScripterYoda @shaka-bot